Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@nx/angular 20.2.0-beta.5 still has a peerDependency that enforces < Angular 19 #29163

Closed
4 tasks
jinder opened this issue Dec 3, 2024 · 0 comments · Fixed by #29164
Closed
4 tasks

@nx/angular 20.2.0-beta.5 still has a peerDependency that enforces < Angular 19 #29163

jinder opened this issue Dec 3, 2024 · 0 comments · Fixed by #29164

Comments

@jinder
Copy link

jinder commented Dec 3, 2024

Current Behavior

When doing NPM install after an Angular 19 upgrade using the latest Nx beta, I'm getting peer dependency warnings because the peer dependencies for @nx/angular hasn't been updated to account for Angular 19 for the @angular-devkit packages.

Expected Behavior

Should not get peer dependency warnings

GitHub Repo

No response

Steps to Reproduce

  1. Upgrade an Angular 18 project to Angular 19 using latest beta
  2. Run npm install

Nx Report

(Unable to provide due to work machine access).

Failure Logs

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

leosvelperez added a commit that referenced this issue Dec 3, 2024
…alone` when not set (#29164)

- Add migration to disable the `@angular-eslint/prefer-standalone` rule
when it's not already set. This prevents a breaking change due to the
[rule being promoted to the recommended rules in
v19](angular-eslint/angular-eslint@8dfdc4f).
- Update the `@nx/angular` package peer dependencies range to drop
Angular v16 and include Angular v20.

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #29163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant