Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): adding e2e projects should register e2e-ci targetDefaults #27185

Merged
merged 22 commits into from
Aug 7, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jul 29, 2024

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2024 3:50pm

@Coly010 Coly010 changed the title feat(devkit): add util for adding e2e-ci target defaults fix(testing): adding e2e projects should register e2e-ci targetDefaults Jul 29, 2024
@Coly010 Coly010 force-pushed the e2e-ci-target-defaults branch 3 times, most recently from c5e2263 to 21ee22a Compare July 31, 2024 08:08
@Coly010 Coly010 marked this pull request as ready for review July 31, 2024 12:19
@Coly010 Coly010 requested review from a team, FrozenPandaz and vsavkin as code owners July 31, 2024 12:19
@Coly010 Coly010 requested a review from jaysoo July 31, 2024 12:19
@Coly010 Coly010 force-pushed the e2e-ci-target-defaults branch from 70b1ace to 1b2bf72 Compare August 2, 2024 15:09
@Coly010 Coly010 force-pushed the e2e-ci-target-defaults branch from 74e3b1b to c9c6731 Compare August 2, 2024 16:15
@Coly010 Coly010 force-pushed the e2e-ci-target-defaults branch from d344793 to 01b7536 Compare August 7, 2024 15:38
@FrozenPandaz FrozenPandaz merged commit dfd7241 into master Aug 7, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the e2e-ci-target-defaults branch August 7, 2024 16:25
ZackDeRose pushed a commit to ZackDeRose/nx that referenced this pull request Aug 8, 2024
…ts (nrwl#27185)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->



## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants