Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): format global config files modified by nx migrate #27066

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

leosvelperez
Copy link
Member

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #8928

@leosvelperez leosvelperez self-assigned this Jul 23, 2024
@leosvelperez leosvelperez requested a review from a team as a code owner July 23, 2024 13:18
@leosvelperez leosvelperez requested a review from xiongemi July 23, 2024 13:18
Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 6:32am

@FrozenPandaz
Copy link
Collaborator

Is this issue related? #25122

@leosvelperez
Copy link
Member Author

Is this issue related? #25122

That one is due to some migration generators not formatting files at the end. I created a separate PR for it: #27082.

@leosvelperez leosvelperez force-pushed the core/nx-migrate-format-files branch from 8bc9b48 to e29bcc9 Compare July 24, 2024 06:29
@FrozenPandaz FrozenPandaz merged commit e9d9c9f into master Jul 25, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the core/nx-migrate-format-files branch July 25, 2024 13:22
FrozenPandaz pushed a commit that referenced this pull request Jul 30, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #8928

(cherry picked from commit e9d9c9f)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx migrate doesn't respect configured indent_size
2 participants