nx repair generates diff due to incorrect formatting
#25122
Assignees
Labels
Comments
FrozenPandaz
pushed a commit
that referenced
this issue
Jul 24, 2024
…27082) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #25122 (cherry picked from commit 8afd3ea)
|
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current Behavior
When running
nx repairon a repo, thenx.jsonfile is updated in a way that is different from the format specified by.prettierrc. When runningnx format:writeafter, the generated diff is gone.This means that
nx repairgeneratesnx.jsonthat is unstable.Expected Behavior
The updated
nx.jsoncreated by runningnx repairshould be properly formatted by prettier.GitHub Repo
https://github.com/terrymun/nx-repair-prettier
Steps to Reproduce
nx repairnx.jsonis updated: the diff is coming solely from formattingnx format:write: notice that diff disappearsThis suggests that the output of
nx repairis not property formatted. I would expect the files generated bynx repairis already properly formatted, because we runnx format:checkin our CI pipeline to ensure that PRs are properly formatted. A team member who just rannx repairmay commit the changes without knowing it is not correctly violated. Of course this can be fixed with a pre-push hook, but I would expect formatting to be part of the job done bynx repair.Nx Report
Failure Logs
No response
Package Manager Version
4.1.0
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: