feat(core): error when running atomized tasks outside of DTE #26898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d6a791a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
MaxKless
force-pushed
the
atomized-error-outside-dte
branch
from
322a99c to
db7724c
Compare
MaxKless
force-pushed
the
atomized-error-outside-dte
branch
from
db7724c to
0693e21
Compare
This comment was marked as outdated.
This comment was marked as outdated.
FrozenPandaz
requested changes
Jul 11, 2024
MaxKless
force-pushed
the
atomized-error-outside-dte
branch
from
73bfe19 to
2a768a5
Compare
MaxKless
force-pushed
the
atomized-error-outside-dte
branch
from
2a768a5 to
0eb2f2e
Compare
MaxKless
force-pushed
the
atomized-error-outside-dte
branch
from
92aadf0 to
f8b3759
Compare
MaxKless
force-pushed
the
atomized-error-outside-dte
branch
from
f8b3759 to
f974505
Compare
MaxKless
force-pushed
the
atomized-error-outside-dte
branch
from
f974505 to
984dfaf
Compare
This comment was marked as outdated.
This comment was marked as outdated.
MaxKless
force-pushed
the
atomized-error-outside-dte
branch
from
984dfaf to
7e6ad73
Compare
MaxKless
force-pushed
the
atomized-error-outside-dte
branch
from
7e6ad73 to
a35cd85
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
MaxKless
force-pushed
the
atomized-error-outside-dte
branch
from
bf1fe0e to
37d7ab9
Compare
MaxKless
force-pushed
the
atomized-error-outside-dte
branch
from
37d7ab9 to
fe80faf
Compare
FrozenPandaz
requested changes
Jul 22, 2024
FrozenPandaz
approved these changes
Jul 23, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 24, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior Nx allows running atomized tasks (like `e2e-ci`) anywhere. ## Expected Behavior Nx allows running atomized tasks (like `e2e-ci`) only in distributed environments like Nx Agents or DTE. We'll leave that actual check to nx cloud but in the default runner, we'll throw an error. It's possible to escape from this with an env var. (cherry picked from commit 184e83a)
This was referenced Jul 26, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Nx allows running atomized tasks (like
e2e-ci) anywhere.Expected Behavior
Nx allows running atomized tasks (like
e2e-ci) only in distributed environments like Nx Agents or DTE. We'll leave that actual check to nx cloud but in the default runner, we'll throw an error.It's possible to escape from this with an env var.