fix(core): pass env vars to e2es that are relevant for atomizer

nrwl · Jul 16, 2024 · f8b3759 · f8b3759
1 parent 0eb2f2e
commit f8b3759
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/docs/generated/packages/nx/executors/atomizer.json b/docs/generated/packages/nx/executors/atomizer.json
@@ -4,7 +4,7 @@
   "schema": {
     "version": 2,
     "title": "Atomizer",
-    "description": "An executor that is used as the root task for atomized tasks. Ensures it's being run in distribution and otherwise does nothing.",
+    "description": "An executor that is used as the root task for atomized tasks. Ensures it's being run in distribution and otherwise does nothing. [Learn more about the Atomizer, its benefits and why you should only run it with distribution.](https://nx.dev/ci/features/split-e2e-tasks#benefits) ",
     "type": "object",
     "cli": "nx",
     "outputCapture": "pipe",

diff --git a/e2e/jest/src/jest.test.ts b/e2e/jest/src/jest.test.ts
@@ -2,6 +2,7 @@ import { stripIndents } from '@angular-devkit/core/src/utils/literals';
 import {
   cleanupProject,
   expectJestTestsToPass,
+  getStrippedEnvironmentVariables,
   newProject,
   runCLI,
   runCLIAsync,
@@ -163,7 +164,9 @@ describe('Jest', () => {
 
     await runCLIAsync(`e2e-ci ${libName}`, {
       env: {
-        NX_SKIP_ATOMIZER_VALIDATION: 'true',
+        ...getStrippedEnvironmentVariables(),
+        // e2e-ci will only run with DTE so we set this for local testing
+        NX_AGENT_NAME: process.env['NX_AGENT_NAME'] ?? 'fake-agent-00',
       },
     });
   }, 90000);

diff --git a/e2e/next/src/next.test.ts b/e2e/next/src/next.test.ts
@@ -196,7 +196,8 @@ describe('Next.js Applications', () => {
       const e2eResults = runCLI(`e2e-ci ${appName}-e2e --verbose`, {
         verbose: true,
         env: {
-          NX_SKIP_ATOMIZER_VALIDATION: 'true',
+          // e2e-ci will only run with DTE so we set this for local testing
+          NX_AGENT_NAME: process.env['NX_AGENT_NAME'] ?? 'fake-agent-00',
         },
       });
       expect(e2eResults).toContain(

diff --git a/packages/nx/src/executors/atomizer/schema.json b/packages/nx/src/executors/atomizer/schema.json
@@ -1,7 +1,7 @@
 {
   "version": 2,
   "title": "Atomizer",
-  "description": "An executor that is used as the root task for atomized tasks. Ensures it's being run in distribution and otherwise does nothing.",
+  "description": "An executor that is used as the root task for atomized tasks. Ensures it's being run in distribution and otherwise does nothing. [Learn more about the Atomizer, its benefits and why you should only run it with distribution.](https://nx.dev/ci/features/split-e2e-tasks#benefits) ",
   "type": "object",
   "cli": "nx",
   "outputCapture": "pipe",