Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): ensure given preid modifies conventional commits specifier #26524

Merged
merged 4 commits into from
Jun 12, 2024
Merged

fix(release): ensure given preid modifies conventional commits specifier #26524

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0858e4
fix(release): ensure given preid modifies conventional commits specifier
JamesHenry Jun 12, 2024
92fc870
chore(release): format
JamesHenry Jun 12, 2024
eeb009b
fix(release): improve description of preid
JamesHenry Jun 12, 2024
f52e288
fix(release): improve description of preid
JamesHenry Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/js/src/generators/release-version/release-version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,8 +406,13 @@ To fix this you will either need to add a package.json file at that location, or
`📄 Resolved the specifier as "${specifier}" since the current version is a prerelease.`
);
} else {
let extraText = '';
if (options.preid && !specifier.startsWith('pre')) {
specifier = `pre${specifier}`;
extraText = `, combined with your given preid "${options.preid}"`;
}
log(
`📄 Resolved the specifier as "${specifier}" using git history and the conventional commits standard.`
`📄 Resolved the specifier as "${specifier}" using git history and the conventional commits standard${extraText}.`
);
}
break;
Expand Down