-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(release): ensure given preid modifies conventional commits specifier #26524
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f52e288. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Not sure about overall prerelease flow implications
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
If a user passes
--preid
when using conventional commits it will not have any impact on the derived specifier. If they were to use an explicit--specifier
to work around this, it would override the derived conventional commits specifier entirely which is not we they want.Expected Behavior
If a user passes
--preid
and the resolved conventional commits specifier is not already a prerelease of some kind, modify the specifier dynamically to be a prerelease (which will later be combined with the given preid).Example (after a breaking change to bar):
Related Issue(s)
Fixes #23235