Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): ensure given preid modifies conventional commits specifier #26524

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

JamesHenry
Copy link
Collaborator

@JamesHenry JamesHenry commented Jun 12, 2024

Current Behavior

If a user passes --preid when using conventional commits it will not have any impact on the derived specifier. If they were to use an explicit --specifier to work around this, it would override the derived conventional commits specifier entirely which is not we they want.

Expected Behavior

If a user passes --preid and the resolved conventional commits specifier is not already a prerelease of some kind, modify the specifier dynamically to be a prerelease (which will later be combined with the given preid).

Example (after a breaking change to bar):

image

Related Issue(s)

Fixes #23235

@JamesHenry JamesHenry requested a review from a team as a code owner June 12, 2024 12:20
@JamesHenry JamesHenry requested a review from jaysoo June 12, 2024 12:20
Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jun 12, 2024 2:55pm

@JamesHenry JamesHenry enabled auto-merge (squash) June 12, 2024 12:23
@JamesHenry JamesHenry self-assigned this Jun 12, 2024
fahslaj
fahslaj previously approved these changes Jun 12, 2024
@fahslaj fahslaj dismissed their stale review June 12, 2024 14:24

Not sure about overall prerelease flow implications

@JamesHenry JamesHenry merged commit 2ba4cf2 into master Jun 12, 2024
6 checks passed
@JamesHenry JamesHenry deleted the conventional-commits-preid branch June 12, 2024 18:23
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx release output wrong prerelease tag & versions both package.json
4 participants