Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): install @typescript-eslint/utils when using relevant angular eslint v18 packages #26418

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Jun 6, 2024

Current Behavior

Angular ESLint v18 packages now have @typescript-eslint/utils as a peer dependency, but new projects don't install it, and existing projects are not getting it installed in a migration.

Expected Behavior

The @typescript-eslint/utils should be installed when creating new Angular projects and when migrating when the workspace has the relevant Angular ESLint packages in v18.

Related Issue(s)

Fixes #26408

@leosvelperez leosvelperez self-assigned this Jun 6, 2024
@leosvelperez leosvelperez requested a review from a team as a code owner June 6, 2024 13:53
@leosvelperez leosvelperez requested a review from FrozenPandaz June 6, 2024 13:53
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 1:56pm

@leosvelperez leosvelperez requested a review from Coly010 June 6, 2024 14:01
@leosvelperez leosvelperez merged commit 15e1f78 into master Jun 6, 2024
6 checks passed
@leosvelperez leosvelperez deleted the angular/install-typescript-eslint-utils branch June 6, 2024 14:54
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to load plugin '@angular-eslint' after migrating to 19.2.0
2 participants