Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to load plugin '@angular-eslint' after migrating to 19.2.0 #26408

Closed
4 tasks
ArielGueta opened this issue Jun 6, 2024 · 2 comments · Fixed by #26418
Closed
4 tasks

Failed to load plugin '@angular-eslint' after migrating to 19.2.0 #26408

ArielGueta opened this issue Jun 6, 2024 · 2 comments · Fixed by #26418
Assignees
Labels
outdated scope: angular Issues related to Angular support in Nx scope: linter Issues related to Eslint support in Nx type: bug

Comments

@ArielGueta
Copy link

Current Behavior

Running nx lint give this error:

Failed to load plugin '@angular-eslint' declared in 'foo/.eslintrc.json » ../.eslintrc.json#overrides[0] » plugin:@nx/angular': Cannot find module '@typescript-eslint/utils'

Expected Behavior

No error

GitHub Repo

No response

Steps to Reproduce

Migrate

Nx Report

Node   : 20.11.1
OS     : darwin-arm64
npm    : 10.2.4

nx                 : 19.2.0
@nx/js             : 19.2.0
@nx/jest           : 19.2.0
@nx/linter         : 19.2.0
@nx/eslint         : 19.2.0
@nx/workspace      : 19.2.0
@nx/angular        : 19.2.0
@nx/devkit         : 19.2.0
@nx/eslint-plugin  : 19.2.0
@nx/playwright     : 19.2.0
@nx/plugin         : 19.2.0
@nrwl/tao          : 19.2.0
@nx/vite           : 19.2.0
@nx/web            : 19.2.0
@nx/webpack        : 19.2.0
typescript         : 5.4.5

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

@ArielGueta
Copy link
Author

Revert from:

"@angular-eslint/eslint-plugin": "^18.0.1",
"@angular-eslint/eslint-plugin-template": "18.0.1",
"@angular-eslint/template-parser": "18.0.1",

to:
"@angular-eslint/eslint-plugin": "^17.3.0",
"@angular-eslint/eslint-plugin-template": "17.3.0",
"@angular-eslint/template-parser": "17.3.0",

fix the issue, but it's still an issue

@leosvelperez leosvelperez added the scope: linter Issues related to Eslint support in Nx label Jun 6, 2024
@leosvelperez leosvelperez self-assigned this Jun 6, 2024
@leosvelperez leosvelperez added the scope: angular Issues related to Angular support in Nx label Jun 6, 2024
leosvelperez added a commit that referenced this issue Jun 6, 2024
…gular eslint v18 packages (#26418)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

Angular ESLint v18 packages now have `@typescript-eslint/utils` as a
peer dependency, but new projects don't install it, and existing
projects are not getting it installed in a migration.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

The `@typescript-eslint/utils` should be installed when creating new
Angular projects and when migrating when the workspace has the relevant
Angular ESLint packages in v18.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #26408
Copy link

github-actions bot commented Jul 8, 2024

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: angular Issues related to Angular support in Nx scope: linter Issues related to Eslint support in Nx type: bug
Projects
None yet
2 participants