Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundling): crystalize rollup #22045

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 28, 2024

Current Behavior

Rollup does not have a Crystal Plugin

Expected Behavior

Rollup has a Crystal Plugin:

  • It will look for rollup.config.{js,mjs,cjs} files.
  • It will add a build target
  • It will use `rollup -c {rollupConfigFileName}
  • It will read the config file using rollup's loadConfigFile util
  • It will parse the output of the config to determine the outputs that will be created and use them for Nx caching

Tested on: https://github.com/freeCodeCamp/freeCodeCamp/tree/main/tools/ui-components

Related Issue(s)

Fixes #

@Coly010 Coly010 requested review from FrozenPandaz, vsavkin and a team as code owners February 28, 2024 15:34
@Coly010 Coly010 self-assigned this Feb 28, 2024
@Coly010 Coly010 requested review from JamesHenry and jaysoo February 28, 2024 15:34
Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 29, 2024 3:30pm

@Coly010 Coly010 enabled auto-merge (squash) February 29, 2024 17:34
@AgentEnder AgentEnder disabled auto-merge February 29, 2024 18:56
@AgentEnder AgentEnder merged commit 729e0a1 into nrwl:master Feb 29, 2024
6 checks passed
@Coly010 Coly010 deleted the rollup/crystalise branch February 29, 2024 20:34
Copy link

github-actions bot commented Mar 6, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants