feat(bundling): crystalize rollup

docs/generated/packages/rollup/generators/init.json

@@ -24,6 +24,12 @@
         "x-priority": "internal",
         "description": "Keep existing dependencies versions",
         "default": false
+      },
+      "updatePackageScripts": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Update `package.json` scripts with inferred targets",
+        "default": false
       }
     },
     "required": [],

e2e/rollup/src/rollup.test.ts

@@ -161,4 +161,53 @@ describe('Rollup Plugin', () => {
     expect(() => runCLI(`build ${jsLib}`)).not.toThrow();
     checkFilesExist(`dist/test/index.mjs.js`);
   });
+
+  it('should build correctly with crystal', () => {
+    // ARRANGE
+    updateFile(
+      `libs/test/src/index.ts`,
+      `export function helloWorld() {
+      console.log("hello world");
+    }`
+    );
+    updateFile(`libs/test/package.json`, JSON.stringify({ name: 'test' }));
+    updateFile(
+      `libs/test/rollup.config.js`,
+      `import babel from '@rollup/plugin-babel';
+import commonjs from '@rollup/plugin-commonjs';
+import typescript2 from 'rollup-plugin-typescript2';
+
+const config = {
+  input: 'src/index.ts',
+  output: [
+    {
+      file: 'dist/bundle.js',
+      format: 'cjs',
+      sourcemap: true
+    },
+    {
+      file: 'dist/bundle.es.js',
+      format: 'es',
+      sourcemap: true
+    }
+  ],
+  plugins: [
+    typescript2(),
+    babel({ babelHelpers: 'bundled' }),
+    commonjs(),
+  ]
+};
+
+export default config;
+`
+    );
+    // ACT
+    runCLI(`generate @nx/rollup:init --no-interactive`);
+    const output = runCLI(`build test`);
+
+    // ASSERT
+    expect(output).toContain('Successfully ran target build for project test');
+    checkFilesExist(`libs/test/dist/bundle.js`);
+    checkFilesExist(`libs/test/dist/bundle.es.js`);
+  });
 });

packages/nx/src/command-line/init/init-v2.ts

@@ -145,6 +145,7 @@ const npmPackageToPluginMap: Record<string, string> = {
   vite: '@nx/vite',
   vitest: '@nx/vite',
   webpack: '@nx/webpack',
+  rollup: '@nx/rollup',
   // Testing tools
   jest: '@nx/jest',
   cypress: '@nx/cypress',

packages/rollup/plugin.ts

@@ -0,0 +1 @@
+export { createNodes, RollupPluginOptions } from './src/plugins/plugin';

packages/rollup/project.json

@@ -8,6 +8,11 @@
     "build-base": {
       "executor": "@nx/js:tsc",
       "options": {
+        "generateExportsField": true,
+        "additionalEntryPoints": [
+          "{projectRoot}/{executors,generators,migrations}.json",
+          "{projectRoot}/plugin.ts"
+        ],
         "assets": [
           {
             "input": "packages/rollup",

packages/rollup/src/generators/init/init.ts

@@ -3,9 +3,37 @@ import {
   formatFiles,
   GeneratorCallback,
   Tree,
+  readNxJson,
+  updateNxJson,
 } from '@nx/devkit';
 import { nxVersion } from '../../utils/versions';
 import { Schema } from './schema';
+import { updatePackageScripts } from '@nx/devkit/src/utils/update-package-scripts';
+import { createNodes } from '../../plugins/plugin';
+
+function addPlugin(tree: Tree) {
+  const nxJson = readNxJson(tree);
+  nxJson.plugins ??= [];
+
+  for (const plugin of nxJson.plugins) {
+    if (
+      typeof plugin === 'string'
+        ? plugin === '@nx/rollup/plugin'
+        : plugin.plugin === '@nx/rollup/plugin'
+    ) {
+      return;
+    }
+  }
+
+  nxJson.plugins.push({
+    plugin: '@nx/rollup/plugin',
+    options: {
+      buildTargetName: 'build',
+    },
+  });
+
+  updateNxJson(tree, nxJson);
+}
 
 export async function rollupInitGenerator(tree: Tree, schema: Schema) {
   let task: GeneratorCallback = () => {};
@@ -20,6 +48,15 @@ export async function rollupInitGenerator(tree: Tree, schema: Schema) {
     );
   }
 
+  schema.addPlugin ??= process.env.NX_ADD_PLUGINS !== 'false';
+  if (schema.addPlugin) {
+    addPlugin(tree);
+  }
+
+  if (schema.updatePackageScripts) {
+    await updatePackageScripts(tree, createNodes);
+  }
+
   if (!schema.skipFormat) {
     await formatFiles(tree);
   }

packages/rollup/src/generators/init/schema.d.ts

@@ -2,4 +2,6 @@ export interface Schema {
   skipFormat?: boolean;
   skipPackageJson?: boolean;
   keepExistingVersions?: boolean;
+  updatePackageScripts?: boolean;
+  addPlugin?: boolean;
 }

packages/rollup/src/generators/init/schema.json

@@ -21,6 +21,12 @@
       "x-priority": "internal",
       "description": "Keep existing dependencies versions",
       "default": false
+    },
+    "updatePackageScripts": {
+      "type": "boolean",
+      "x-priority": "internal",
+      "description": "Update `package.json` scripts with inferred targets",
+      "default": false
     }
   },
   "required": []

packages/rollup/src/plugins/__snapshots__/plugin.spec.ts.snap

@@ -0,0 +1,60 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`@nx/rollup/plugin non-root project should create nodes 1`] = `
+{
+  "projects": {
+    "mylib": {
+      "root": "mylib",
+      "targets": {
+        "build": {
+          "cache": true,
+          "command": "rollup -c rollup.config.js",
+          "dependsOn": [
+            "^build",
+          ],
+          "inputs": [
+            "production",
+            "^production",
+          ],
+          "options": {
+            "cwd": "mylib",
+          },
+          "outputs": [
+            "{workspaceRoot}/mylib/build",
+            "{workspaceRoot}/mylib/dist",
+          ],
+        },
+      },
+    },
+  },
+}
+`;
+
+exports[`@nx/rollup/plugin root project should create nodes 1`] = `
+{
+  "projects": {
+    ".": {
+      "root": ".",
+      "targets": {
+        "build": {
+          "cache": true,
+          "command": "rollup -c rollup.config.js",
+          "dependsOn": [
+            "^build",
+          ],
+          "inputs": [
+            "production",
+            "^production",
+          ],
+          "options": {
+            "cwd": ".",
+          },
+          "outputs": [
+            "{workspaceRoot}/dist",
+          ],
+        },
+      },
+    },
+  },
+}
+`;

packages/rollup/src/plugins/plugin.spec.ts

@@ -0,0 +1,155 @@
+import { type CreateNodesContext, joinPathFragments } from '@nx/devkit';
+import { createNodes } from './plugin';
+import { TempFs } from 'nx/src/internal-testing-utils/temp-fs';
+
+describe('@nx/rollup/plugin', () => {
+  let createNodesFunction = createNodes[1];
+  let context: CreateNodesContext;
+  let cwd = process.cwd();
+
+  describe('root project', () => {
+    const tempFs = new TempFs('test');
+
+    beforeEach(() => {
+      context = {
+        nxJsonConfiguration: {
+          targetDefaults: {
+            build: {
+              cache: false,
+              inputs: ['foo', '^foo'],
+            },
+          },
+          namedInputs: {
+            default: ['{projectRoot}/**/*'],
+            production: ['!{projectRoot}/**/*.spec.ts'],
+          },
+        },
+        workspaceRoot: tempFs.tempDir,
+      };
+
+      tempFs.createFileSync('package.json', JSON.stringify({ name: 'mylib' }));
+      tempFs.createFileSync(
+        'src/index.js',
+        `export function main() { 
+      console.log("hello world");
+      }`
+      );
+      tempFs.createFileSync(
+        'rollup.config.js',
+        `
+const config = {
+  input: 'src/index.js',
+  output: [
+    {
+      file: 'dist/bundle.js',
+      format: 'cjs',
+      sourcemap: true
+    },
+    {
+      file: 'dist/bundle.es.js',
+      format: 'es',
+      sourcemap: true
+    }
+  ],
+  plugins: [],
+};
+
+module.exports = config;
+      `
+      );
+
+      process.chdir(tempFs.tempDir);
+    });
+
+    afterEach(() => {
+      jest.resetModules();
+      tempFs.cleanup();
+      process.chdir(cwd);
+    });
+
+    it('should create nodes', async () => {
+      // ACT
+      const nodes = await createNodesFunction(
+        'rollup.config.js',
+        {
+          buildTargetName: 'build',
+        },
+        context
+      );
+
+      // ASSERT
+      expect(nodes).toMatchSnapshot();
+    });
+  });
+  describe('non-root project', () => {
+    const tempFs = new TempFs('test');
+
+    beforeEach(() => {
+      context = {
+        nxJsonConfiguration: {
+          namedInputs: {
+            default: ['{projectRoot}/**/*'],
+            production: ['!{projectRoot}/**/*.spec.ts'],
+          },
+        },
+        workspaceRoot: tempFs.tempDir,
+      };
+
+      tempFs.createFileSync(
+        'mylib/package.json',
+        JSON.stringify({ name: 'mylib' })
+      );
+      tempFs.createFileSync(
+        'mylib/src/index.js',
+        `export function main() { 
+      console.log("hello world");
+      }`
+      );
+      tempFs.createFileSync(
+        'mylib/rollup.config.js',
+        `
+const config = {
+  input: 'src/index.js',
+  output: [
+    {
+      file: 'build/bundle.js',
+      format: 'cjs',
+      sourcemap: true
+    },
+    {
+      file: 'dist/bundle.es.js',
+      format: 'es',
+      sourcemap: true
+    }
+  ],
+  plugins: [],
+};
+
+module.exports = config;
+      `
+      );
+
+      process.chdir(tempFs.tempDir);
+    });
+
+    afterEach(() => {
+      jest.resetModules();
+      tempFs.cleanup();
+      process.chdir(cwd);
+    });
+
+    it('should create nodes', async () => {
+      // ACT
+      const nodes = await createNodesFunction(
+        'mylib/rollup.config.js',
+        {
+          buildTargetName: 'build',
+        },
+        context
+      );
+
+      // ASSERT
+      expect(nodes).toMatchSnapshot();
+    });
+  });
+});