fix(react-native): storybook relative paths #22031
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit adc37ac. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
|
looks good. could you rebase the pr? |
arekkubaczkowski
requested review from
FrozenPandaz,
jaysoo,
AgentEnder,
a team,
vsavkin,
meeroslav,
mandarini,
leosvelperez,
Coly010,
philipjfulcher,
bcabanes and
MaxKless
as code owners
arekkubaczkowski
requested review from
StalkAltan,
rarmatei and
JamesHenry
as code owners
well... rebase didn't go my way... Edit: managed to fixed that. Let me know if docs changes should be there 🤔 |
arekkubaczkowski
force-pushed
the
arekkubaczkowski/fix-storybook-relative-story-paths
branch
from
ad55f79 to
df97f95
Compare
| @@ -15,6 +12,9 @@ Use [validateDependency](../../devkit/documents/validateDependency) to validate | |||
|
|
|||
| ▸ (`options`, `context`): [`RawProjectGraphDependency`](../../devkit/documents/RawProjectGraphDependency)[] \| `Promise`\<[`RawProjectGraphDependency`](../../devkit/documents/RawProjectGraphDependency)[]\> | |||
|
|
|||
| A function which parses files in the workspace to create dependencies in the [ProjectGraph](../../devkit/documents/ProjectGraph) | |||
There was a problem hiding this comment.
the docs should not be changed. could you run pnpm documentation and make sure no docs got updated?
There was a problem hiding this comment.
as you said, no docs updated after pnpm documentation. Should I revert those file or you have a better idea?
There was a problem hiding this comment.
could you revert the doc changes?
There was a problem hiding this comment.
@xiongemi done
Co-authored-by: Emily Xiong <[email protected]> (cherry picked from commit 120cde6)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Currently the paths generated by storybook executor are relative against to workspace root path which cannot be resolved properly by metro that fails during the build phase.
Expected Behavior
Story files are supposed to be relative to the loader-path file so it can be resolved correctly.
relates #22009