Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to disable sync-deps from @nx/react-native:storybook executor #22009

Closed
1 task done
arekkubaczkowski opened this issue Feb 27, 2024 · 2 comments · Fixed by #22032
Closed
1 task done

Allow to disable sync-deps from @nx/react-native:storybook executor #22009

arekkubaczkowski opened this issue Feb 27, 2024 · 2 comments · Fixed by #22032
Assignees
@xiongemi
Labels
outdated scope: react-native Issues relating to React Native type: feature

Comments

@arekkubaczkowski
Copy link
Contributor

arekkubaczkowski commented Feb 27, 2024 •
edited
Loading

Description

As per concerns mentioned under this issue #18788 there are some circumstances when you don't want to use sync-deps for react native app. That option would allow to choose whether developer wants to use it or not. That option would be consistent with the other executors like those from @nx/expo which implement dependsOn param.

Motivation

Suggested Implementation

Add optional dependsOn param to @nx/react-native:storybook executor that would accept sync-deps in an array.

Alternate Implementations
@arekkubaczkowski
Copy link
Contributor Author

I have also just noticed that storybook executor produces wrong paths for stories in story-loader.ts file.
It generates absolute paths regardless of the outputFile param and metro fails during bundling.

arekkubaczkowski added a commit to arekkubaczkowski/nx that referenced this issue Feb 28, 2024
@arekkubaczkowski
feat(react-native): add optional syncDeps param to storybook executor
b0f3faf 
closed nrwl#22009
This was referenced Feb 28, 2024
Merged
Merged
@AgentEnder AgentEnder added the scope: react-native Issues relating to React Native label Mar 4, 2024
xiongemi pushed a commit that referenced this issue May 14, 2024
@arekkubaczkowski
feat(react-native): add optional syncDeps param to storybook executor (…
d4140b0 
…#22032)

closed #22009

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
storybook executor runs syncDeps automatically without option to disable
it

## Expected Behavior
as per #22009 we might need to disable syncDeps step at some
circumstances.
FrozenPandaz pushed a commit that referenced this issue May 14, 2024
@arekkubaczkowski @FrozenPandaz
feat(react-native): add optional syncDeps param to storybook executor (…
d9c5fe9 
…#22032)

closed #22009

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
storybook executor runs syncDeps automatically without option to disable
it

## Expected Behavior
as per #22009 we might need to disable syncDeps step at some
circumstances.

(cherry picked from commit d4140b0)
Coly010 pushed a commit that referenced this issue May 15, 2024
@arekkubaczkowski @Coly010
feat(react-native): add optional syncDeps param to storybook executor (…
6993581 
…#22032)

closed #22009

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
storybook executor runs syncDeps automatically without option to disable
it

## Expected Behavior
as per #22009 we might need to disable syncDeps step at some
circumstances.
@github-actions GitHub Actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xiongemi xiongemi

Labels
outdated scope: react-native Issues relating to React Native type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(react-native): add optional syncDeps param to storybook executor arekkubaczkowski/nx
3 participants
@AgentEnder @xiongemi @arekkubaczkowski