Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): correctly handle parentheses in url #21660

Closed
wants to merge 2 commits into from

Conversation

ryanhaugh
Copy link

#20988 introduced a regression that caused parentheses in url not to be handled correctly.

The referenced PR copies the fix done in angular/angular-cli#23691, but that fix introduced a regression that caused parentheses in url not to be handled correctly. angular/angular-cli#23774 fixed this issue - that's fix that is in this PR.

Current Behavior

Parentheses in url are not handled correctly.

Expected Behavior

Parentheses in url are handled correctly.

Related Issue(s)

Fixes #21656

PR nrwl#20988 introduced a regression that caused parantheses in url not to be handled correctly.

Closes nrwl#21656
@ryanhaugh ryanhaugh requested a review from a team as a code owner February 7, 2024 06:34
@ryanhaugh ryanhaugh requested a review from mandarini February 7, 2024 06:34
Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 14, 2024 8:04pm

@ryanhaugh
Copy link
Author

Hi @mandarini,

Any chance we could get this reviewed? This is preventing us from upgrading to v18.

Thanks!
Ryan

@ghost
Copy link

ghost commented Feb 18, 2024

Same here

Hi @mandarini,

Any chance we could get this reviewed? This is preventing us from upgrading to v18.

Thanks! Ryan

@mandarini
Copy link
Member

@ryanhaugh @danr-za hello! Sorry, I was on PTO, I just returned to work. Can you please rebase & fix e2e tests? I will approve once the pipeline is green! Thank you SO MUCH for your contribution!!

@mandarini
Copy link
Member

Closing because this was merged: #21884

@mandarini mandarini closed this Feb 20, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack regression in v18 due to PR 20988
2 participants