-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack): correctly handle parentheses in url #21660
Conversation
PR nrwl#20988 introduced a regression that caused parantheses in url not to be handled correctly. Closes nrwl#21656
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0a08e6b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
Hi @mandarini, Any chance we could get this reviewed? This is preventing us from upgrading to v18. Thanks! |
Same here
|
@ryanhaugh @danr-za hello! Sorry, I was on PTO, I just returned to work. Can you please rebase & fix e2e tests? I will approve once the pipeline is green! Thank you SO MUCH for your contribution!! |
Closing because this was merged: #21884 |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
#20988 introduced a regression that caused parentheses in url not to be handled correctly.
The referenced PR copies the fix done in angular/angular-cli#23691, but that fix introduced a regression that caused parentheses in url not to be handled correctly. angular/angular-cli#23774 fixed this issue - that's fix that is in this PR.
Current Behavior
Parentheses in url are not handled correctly.
Expected Behavior
Parentheses in url are handled correctly.
Related Issue(s)
Fixes #21656