Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack regression in v18 due to PR 20988 #21656

Closed
4 tasks
ryanhaugh opened this issue Feb 7, 2024 · 2 comments
Closed
4 tasks

Webpack regression in v18 due to PR 20988 #21656

ryanhaugh opened this issue Feb 7, 2024 · 2 comments
Assignees
Labels
outdated scope: bundlers Issues related to webpack, rollup type: bug

Comments

@ryanhaugh
Copy link

Current Behavior

#20988 introduced a Webpack regression in Nx v18 where parentheses aren't handled correctly in url.

20988 copies the fix done in the angular-cli repository: angular/angular-cli#23691, but that fix introduced a regression that caused parentheses in url not to be handled correctly. angular/angular-cli#23774 fixed this issue, and this fix should be implemented in this repo as well.

Expected Behavior

Parentheses in url are handled correctly

GitHub Repo

No response

Steps to Reproduce

  1. Add a test similar to the one here

Nx Report

Node   : 20.11.0
   OS     : darwin-arm64
   npm    : 10.2.4
   
   nx                 : 18.0.2
   @nx/js             : 18.0.2
   @nx/jest           : 18.0.2
   @nx/linter         : 18.0.2
   @nx/eslint         : 18.0.2
   @nx/workspace      : 18.0.2
   @nx/cypress        : 18.0.2
   @nx/devkit         : 18.0.2
   @nx/eslint-plugin  : 18.0.2
   @nx/plugin         : 18.0.2
   @nx/react          : 18.0.2
   @nx/rollup         : 18.0.2
   @nx/storybook      : 18.0.2
   @nrwl/tao          : 18.0.2
   @nx/web            : 18.0.2
   @nx/webpack        : 18.0.2
   typescript         : 5.3.3

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

ryanhaugh pushed a commit to ryanhaugh/nx that referenced this issue Feb 7, 2024
PR nrwl#20988 introduced a regression that caused parantheses in url not to be handled correctly.

Closes nrwl#21656
@AgentEnder AgentEnder added the scope: bundlers Issues related to webpack, rollup label Feb 7, 2024
@Coly010
Copy link
Contributor

Coly010 commented May 13, 2024

Fixed in: #21884

@Coly010 Coly010 closed this as completed May 13, 2024
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: bundlers Issues related to webpack, rollup type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants