Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): adjust terminal run check for crystal #21638

Merged
merged 5 commits into from
Feb 6, 2024
Merged

fix(linter): adjust terminal run check for crystal #21638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3408818
chore(linter): fix and reenable disabled eslint test
meeroslav Feb 5, 2024
44ffd19
chore(linter): add comments and remove env variable
meeroslav Feb 5, 2024
fd9419a
Merge remote-tracking branch 'upstream/master' into fix-other-test
meeroslav Feb 5, 2024
3005566
feat(linter): enable test
meeroslav Feb 6, 2024
04c4575
fix(linter): adjust terminal run check for crystal
meeroslav Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions e2e/eslint/src/linter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,7 @@ describe('Linter', () => {
});
});

// TODO(crystal, @meeroslav): Investigate why this is failing
xit('should report dependency check issues', () => {
it('should report dependency check issues', () => {
const rootPackageJson = readJson('package.json');
const nxVersion = rootPackageJson.devDependencies.nx;
const tslibVersion = rootPackageJson.dependencies['tslib'];
Expand All @@ -476,7 +475,7 @@ describe('Linter', () => {
`libs/${mylib}/src/lib/${mylib}.ts`,
(content) =>
`import { names } from '@nx/devkit';\n\n` +
content.replace(/=> .*;/, `=> names(${mylib}).className;`)
content.replace(/=> .*;/, `=> names('${mylib}').className;`)
);

// output should now report missing dependency
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin/src/utils/runtime-lint-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ export function hasBuildExecutor(
);
}

const ESLINT_REGEX = /node_modules.*[\/\\]eslint$/;
const ESLINT_REGEX = /node_modules.*[\/\\]eslint(?:\.js)?$/;
const JEST_REGEX = /node_modules\/.bin\/jest$/; // when we run unit tests in jest
const NRWL_CLI_REGEX = /nx[\/\\]bin[\/\\]run-executor\.js$/;

Expand Down