-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linter): adjust terminal run check for crystal #21638
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 04c4575. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
(cherry picked from commit f79aabb)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
The terminal command when running manually was
But when running with PCv3 is
This leads to command not being detected as a terminal run and re-fetching package.json from disk even after applying
fix
during the eslint runtime.Current Behavior
The
isTerminalRun
check does not work correctly for Crystal since the argument has a different format than expected.Expected Behavior
The
isTerminalRun
should properly check if the command is ran in the terminal.Related Issue(s)
Fixes #