Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): adjust terminal run check for crystal #21638

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

meeroslav
Copy link
Contributor

The terminal command when running manually was

node_modules/.bin/eslint

But when running with PCv3 is

node_modules/eslint/bin/eslint.js

This leads to command not being detected as a terminal run and re-fetching package.json from disk even after applying fix during the eslint runtime.

Current Behavior

The isTerminalRun check does not work correctly for Crystal since the argument has a different format than expected.

Expected Behavior

The isTerminalRun should properly check if the command is ran in the terminal.

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Feb 6, 2024
@meeroslav meeroslav requested a review from a team as a code owner February 6, 2024 10:57
@meeroslav meeroslav requested a review from JamesHenry February 6, 2024 10:57
Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2024 10:58am

@JamesHenry JamesHenry enabled auto-merge (squash) February 6, 2024 13:45
@JamesHenry JamesHenry merged commit f79aabb into nrwl:master Feb 6, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Feb 7, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants