Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): enable project crystal by default #21403

Merged
merged 66 commits into from
Feb 2, 2024
Merged
Show file tree
Hide file tree
Changes from 55 commits
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
ce21b32
feat(core): enable project crystal by default
FrozenPandaz Jan 29, 2024
9cab2d9
fix(vite): switch e2e tests for crystal and legacy
mandarini Jan 31, 2024
ab02812
fix(storybook): fix output dir for e2e tests
mandarini Jan 31, 2024
2a40448
fix(nuxt): fix storybook output dir for e2e tests
mandarini Jan 31, 2024
b089fb0
fix(vue): fix storybook output dir for e2e tests
mandarini Jan 31, 2024
e376ad5
fix(vite): e2e directories and env var
mandarini Jan 31, 2024
8b3d950
fix(misc): add unsetProjectNameAndRootFormat:false to tests
mandarini Jan 31, 2024
ae27be6
fix(core): ste global graph creation variable in graph creation for p…
FrozenPandaz Jan 31, 2024
332b8fe
fix(core): move global graph creation variable in graph creation for …
FrozenPandaz Jan 31, 2024
a69c426
fix(linter): expand init/migration logic to handle inferred targets
jaysoo Jan 31, 2024
b52d586
chore(linter): fix unit test assertion for eslintrc for plugin
jaysoo Jan 31, 2024
f0a2c67
fix(core): move global graph creation variable in graph creation for …
FrozenPandaz Jan 31, 2024
333eea1
fix(testing): update jest e2e tests
jaysoo Feb 1, 2024
fafa694
fix(testing): update playwright e2e tests
jaysoo Feb 1, 2024
e604234
fix(misc): update "nx init" test to test legacy behavior
jaysoo Feb 1, 2024
d46a449
feat(misc): add backwards compatibility for crystal generators
FrozenPandaz Feb 1, 2024
81b732f
feat(misc): add backwards compatibility for crystal generators
FrozenPandaz Feb 1, 2024
4e8f4b7
fix(misc): update docs
FrozenPandaz Feb 1, 2024
048fe29
fix(misc): fix tests
FrozenPandaz Feb 1, 2024
101ccfc
fix(misc): fix tests
FrozenPandaz Feb 1, 2024
9bcb0fe
fix(misc): fix tests
FrozenPandaz Feb 1, 2024
14edfa6
Merge remote-tracking branch 'origin/master' into crystal-default
FrozenPandaz Feb 1, 2024
ffa4933
fix(misc): e2e updates for vite vue nuxt
mandarini Feb 1, 2024
39b2e27
fix(react): react-core e2e tests
Coly010 Jan 31, 2024
897d6e6
fix(react): react module federation tests
Coly010 Jan 31, 2024
158fcba
fix(testing): fix angular component testing
leosvelperez Feb 1, 2024
299388e
Merge remote-tracking branch 'upstream/master' into crystal-default
mandarini Feb 1, 2024
acfd3ba
fix(misc): remove setMaxWorkers from vue and storybook
mandarini Feb 1, 2024
c54d7c8
fix(react): react-core e2es
Coly010 Feb 1, 2024
d25002c
Merge pull request #12 from Coly010/fix-react-core
FrozenPandaz Feb 1, 2024
982ea97
fix(web): fix @nx/web:app generator and e2e tests
jaysoo Feb 1, 2024
dc3839e
fix(webpack): fix reading tsconfig when passing emitDecoratorMetadata…
jaysoo Feb 1, 2024
69a4614
fix(storybook): fix storybook configuration generators
FrozenPandaz Feb 1, 2024
2fa58cc
fix(misc): remove setMaxWorkers from e2e tests
mandarini Feb 1, 2024
8a0feb1
fix(react): react-vite e2e from react-extensions
mandarini Feb 1, 2024
0fef0d0
fix(testing): fix react cypress component testing e2e tests
leosvelperez Feb 1, 2024
2026830
fix(react): unit tests
Coly010 Feb 1, 2024
4904724
chore(misc): fix tests
jaysoo Feb 1, 2024
9a6c36a
Merge pull request #13 from Coly010/fix-unit-tests
FrozenPandaz Feb 1, 2024
dcf60c1
fix(react-native): fix react native e2e tests
xiongemi Feb 1, 2024
bba3fb8
fix(web): update snapshots
mandarini Feb 1, 2024
d0ebcc8
Merge remote-tracking branch 'jason/crystal-default' into crystal-def…
mandarini Feb 1, 2024
4db6103
fix(nextjs): some changes to e2e tests
mandarini Feb 1, 2024
b52a95c
Merge pull request #11 from leosvelperez/crystal/cypress-ct
FrozenPandaz Feb 1, 2024
658aaa5
fix(testing): fix next cypress component testing e2e tests
leosvelperez Feb 1, 2024
c1992c5
fix(js): add target default for build executors for js lib
FrozenPandaz Feb 1, 2024
6ef7f24
chore(misc): fix web tests
jaysoo Feb 1, 2024
993022e
fix(webpack): generate config with absolute output path
jaysoo Feb 1, 2024
977af15
fix(core): Fix js e2e node missing asset path
ndcunningham Feb 1, 2024
1be1468
fix(next): remove deprecated file-loader and fix e2e tests
jaysoo Feb 1, 2024
55fb3a2
fix(repo): fix lockfile
FrozenPandaz Feb 1, 2024
a390373
Merge remote-tracking branch 'origin/master' into crystal-default
FrozenPandaz Feb 1, 2024
40bb0b8
fix(misc): fix nx-misc extra e2e tests
xiongemi Feb 1, 2024
61bee0b
fix(testing): fix e2e-nx-run tests
xiongemi Feb 1, 2024
79f6eb9
fix(react-native): fix expo e2e lint test
xiongemi Feb 1, 2024
a4a1a0b
fix(node): E2E turn off crystal for node-webpack for now
ndcunningham Feb 2, 2024
58e0a45
Merge remote-tracking branch 'origin/master' into crystal-default
FrozenPandaz Feb 2, 2024
0f3ed04
Merge remote-tracking branch 'origin/master' into crystal-default
FrozenPandaz Feb 2, 2024
9dbcda2
chore(misc): fix e2e tests
FrozenPandaz Feb 2, 2024
ebeab4e
chore(repo): fix e2e tests
FrozenPandaz Feb 2, 2024
a5e6dc2
fix(testing): fix load cypress config for create npm workspace
xiongemi Feb 2, 2024
311984a
chore(repo): fix e2e tests
FrozenPandaz Feb 2, 2024
98c7229
chore(repo): disable failing e2e tests
FrozenPandaz Feb 2, 2024
f05c7f1
chore(repo): disable failing e2e tests
FrozenPandaz Feb 2, 2024
31a96c2
chore(repo): disable failing e2e tests
FrozenPandaz Feb 2, 2024
2c4c22f
chore(repo): disable failing e2e tests
FrozenPandaz Feb 2, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion docs/generated/cli/add.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ The package name and optional version (e.g. `@nx/react` or `@nx/react@latest`) t

Type: `boolean`

Update `package.json` scripts with inferred targets. Defaults to `true` when `NX_PCV3=true` and the package is a core Nx plugin
Update `package.json` scripts with inferred targets. Defaults to `true` when the package is a core Nx plugin

### verbose

Expand Down
34 changes: 1 addition & 33 deletions docs/generated/cli/init.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,36 +17,12 @@ Install `nx` globally to invoke the command directly using `nx`, or use `npx nx`

## Options

### addE2e

Type: `boolean`

Default: `false`

Set up Cypress E2E tests in integrated workspaces. Only for CRA projects.

### force

Type: `boolean`

Default: `false`

Force the migration to continue and ignore custom webpack setup or uncommitted changes. Only for CRA projects.

### help

Type: `boolean`

Show help

### integrated

Type: `boolean`

Default: `false`

Migrate to an Nx integrated layout workspace. Only for Angular CLI workspaces and CRA projects.

### interactive

Type: `boolean`
Expand All @@ -59,7 +35,7 @@ When false disables interactive input prompts for options.

Type: `boolean`

Set up remote caching with Nx Cloud.
Set up distributed caching with Nx Cloud.

### useDotNxInstallation

Expand All @@ -74,11 +50,3 @@ Initialize an Nx workspace setup in the .nx directory of the current repository.
Type: `boolean`

Show version number

### vite

Type: `boolean`

Default: `true`

Use Vite as the bundler. Only for CRA projects.
2 changes: 1 addition & 1 deletion docs/generated/manifests/nx-api.json
Original file line number Diff line number Diff line change
Expand Up @@ -917,7 +917,7 @@
},
"generators": {
"/nx-api/expo/generators/init": {
"description": "Initialize the @nrwl/expo plugin",
"description": "Initialize the @nx/expo plugin",
"file": "generated/packages/expo/generators/init.json",
"hidden": true,
"name": "init",
Expand Down
2 changes: 1 addition & 1 deletion docs/generated/packages-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -903,7 +903,7 @@
],
"generators": [
{
"description": "Initialize the @nrwl/expo plugin",
"description": "Initialize the @nx/expo plugin",
"file": "generated/packages/expo/generators/init.json",
"hidden": true,
"name": "init",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cypress-component-configuration",
"factory": "./src/generators/cypress-component-configuration/cypress-component-configuration",
"factory": "./src/generators/cypress-component-configuration/cypress-component-configuration#cypressComponentConfigurationInternal",
"schema": {
"$schema": "https://json-schema.org/schema",
"$id": "NxAngularCypressComponentConfigurationGenerator",
Expand Down Expand Up @@ -41,7 +41,7 @@
"presets": []
},
"description": "Setup Cypress component testing for a project.",
"implementation": "/packages/angular/src/generators/cypress-component-configuration/cypress-component-configuration.ts",
"implementation": "/packages/angular/src/generators/cypress-component-configuration/cypress-component-configuration#cypressComponentConfigurationInternal.ts",
"aliases": [],
"hidden": false,
"path": "/packages/angular/src/generators/cypress-component-configuration/schema.json",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "component-configuration",
"aliases": ["cypress-component-configuration"],
"factory": "./src/generators/component-configuration/component-configuration",
"factory": "./src/generators/component-configuration/component-configuration#componentConfigurationGeneratorInternal",
"schema": {
"$schema": "https://json-schema.org/schema",
"$id": "NxCypressComponentConfiguration",
Expand Down Expand Up @@ -46,7 +46,7 @@
},
"description": "Set up Cypress Component Test for a project",
"hidden": true,
"implementation": "/packages/cypress/src/generators/component-configuration/component-configuration.ts",
"implementation": "/packages/cypress/src/generators/component-configuration/component-configuration#componentConfigurationGeneratorInternal.ts",
"path": "/packages/cypress/src/generators/component-configuration/schema.json",
"type": "generator"
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "configuration",
"aliases": ["cypress-e2e-configuration", "e2e", "e2e-config"],
"factory": "./src/generators/configuration/configuration",
"factory": "./src/generators/configuration/configuration#configurationGeneratorInternal",
"schema": {
"$schema": "https://json-schema.org/schema",
"$id": "NxCypressE2EConfigGenerator",
Expand Down Expand Up @@ -93,7 +93,7 @@
"presets": []
},
"description": "Add a Cypress E2E Configuration to an existing project.",
"implementation": "/packages/cypress/src/generators/configuration/configuration.ts",
"implementation": "/packages/cypress/src/generators/configuration/configuration#configurationGeneratorInternal.ts",
"hidden": false,
"path": "/packages/cypress/src/generators/configuration/schema.json",
"type": "generator"
Expand Down
4 changes: 2 additions & 2 deletions docs/generated/packages/cypress/generators/init.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "init",
"factory": "./src/generators/init/init#cypressInitGenerator",
"factory": "./src/generators/init/init#cypressInitGeneratorInternal",
"schema": {
"$schema": "https://json-schema.org/schema",
"$id": "NxCypressInit",
Expand Down Expand Up @@ -39,7 +39,7 @@
"description": "Initialize the `@nrwl/cypress` plugin.",
"aliases": ["ng-add"],
"hidden": true,
"implementation": "/packages/cypress/src/generators/init/init#cypressInitGenerator.ts",
"implementation": "/packages/cypress/src/generators/init/init#cypressInitGeneratorInternal.ts",
"path": "/packages/cypress/src/generators/init/schema.json",
"type": "generator"
}
4 changes: 2 additions & 2 deletions docs/generated/packages/detox/generators/init.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "init",
"factory": "./src/generators/init/init#detoxInitGenerator",
"factory": "./src/generators/init/init#detoxInitGeneratorInternal",
"schema": {
"$schema": "https://json-schema.org/schema",
"title": "Add Detox Schematics",
Expand Down Expand Up @@ -37,7 +37,7 @@
},
"description": "Initialize the `@nrwl/detox` plugin.",
"hidden": true,
"implementation": "/packages/detox/src/generators/init/init#detoxInitGenerator.ts",
"implementation": "/packages/detox/src/generators/init/init#detoxInitGeneratorInternal.ts",
"aliases": [],
"path": "/packages/detox/src/generators/init/schema.json",
"type": "generator"
Expand Down
4 changes: 2 additions & 2 deletions docs/generated/packages/eslint/generators/init.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "init",
"factory": "./src/generators/init/init#lintInitGenerator",
"factory": "./src/generators/init/init#initEsLint",
"schema": {
"$schema": "https://json-schema.org/schema",
"cli": "nx",
Expand Down Expand Up @@ -32,7 +32,7 @@
},
"description": "Set up the ESLint plugin.",
"hidden": true,
"implementation": "/packages/eslint/src/generators/init/init#lintInitGenerator.ts",
"implementation": "/packages/eslint/src/generators/init/init#initEsLint.ts",
"aliases": [],
"path": "/packages/eslint/src/generators/init/schema.json",
"type": "generator"
Expand Down
6 changes: 3 additions & 3 deletions docs/generated/packages/expo/generators/init.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "init",
"factory": "./src/generators/init/init#expoInitGenerator",
"factory": "./src/generators/init/init#expoInitGeneratorInternal",
"schema": {
"cli": "nx",
"$id": "NxExpoInit",
Expand Down Expand Up @@ -35,9 +35,9 @@
"required": [],
"presets": []
},
"description": "Initialize the @nrwl/expo plugin",
"description": "Initialize the @nx/expo plugin",
"hidden": true,
"implementation": "/packages/expo/src/generators/init/init#expoInitGenerator.ts",
"implementation": "/packages/expo/src/generators/init/init#expoInitGeneratorInternal.ts",
"aliases": [],
"path": "/packages/expo/src/generators/init/schema.json",
"type": "generator"
Expand Down
4 changes: 2 additions & 2 deletions docs/generated/packages/jest/generators/configuration.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "configuration",
"factory": "./src/generators/configuration/configuration",
"factory": "./src/generators/configuration/configuration#configurationGeneratorInternal",
"schema": {
"$schema": "https://json-schema.org/schema",
"$id": "NxJestProject",
Expand Down Expand Up @@ -82,7 +82,7 @@
},
"description": "Add Jest configuration to a project.",
"hidden": true,
"implementation": "/packages/jest/src/generators/configuration/configuration.ts",
"implementation": "/packages/jest/src/generators/configuration/configuration#configurationGeneratorInternal.ts",
"aliases": [],
"path": "/packages/jest/src/generators/configuration/schema.json",
"type": "generator"
Expand Down
4 changes: 2 additions & 2 deletions docs/generated/packages/jest/generators/init.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "init",
"factory": "./src/generators/init/init#jestInitGenerator",
"factory": "./src/generators/init/init#jestInitGeneratorInternal",
"schema": {
"$schema": "https://json-schema.org/schema",
"$id": "NxJestInit",
Expand Down Expand Up @@ -40,7 +40,7 @@
"description": "Initialize the `@nrwl/jest` plugin.",
"aliases": ["ng-add"],
"hidden": true,
"implementation": "/packages/jest/src/generators/init/init#jestInitGenerator.ts",
"implementation": "/packages/jest/src/generators/init/init#jestInitGeneratorInternal.ts",
"path": "/packages/jest/src/generators/init/schema.json",
"type": "generator"
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cypress-component-configuration",
"factory": "./src/generators/cypress-component-configuration/cypress-component-configuration",
"factory": "./src/generators/cypress-component-configuration/cypress-component-configuration#cypressComponentConfigurationInternal",
"schema": {
"$schema": "https://json-schema.org/schema",
"cli": "nx",
Expand Down Expand Up @@ -45,7 +45,7 @@
"presets": []
},
"description": "cypress-component-configuration generator",
"implementation": "/packages/next/src/generators/cypress-component-configuration/cypress-component-configuration.ts",
"implementation": "/packages/next/src/generators/cypress-component-configuration/cypress-component-configuration#cypressComponentConfigurationInternal.ts",
"aliases": [],
"hidden": false,
"path": "/packages/next/src/generators/cypress-component-configuration/schema.json",
Expand Down
4 changes: 2 additions & 2 deletions docs/generated/packages/next/generators/init.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "init",
"factory": "./src/generators/init/init#nextInitGenerator",
"factory": "./src/generators/init/init#nextInitGeneratorInternal",
"schema": {
"$schema": "https://json-schema.org/schema",
"cli": "nx",
Expand Down Expand Up @@ -38,7 +38,7 @@
},
"description": "Initialize the `@nrwl/next` plugin.",
"hidden": true,
"implementation": "/packages/next/src/generators/init/init#nextInitGenerator.ts",
"implementation": "/packages/next/src/generators/init/init#nextInitGeneratorInternal.ts",
"aliases": [],
"path": "/packages/next/src/generators/init/schema.json",
"type": "generator"
Expand Down
2 changes: 1 addition & 1 deletion docs/generated/packages/nx/documents/add.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ The package name and optional version (e.g. `@nx/react` or `@nx/react@latest`) t

Type: `boolean`

Update `package.json` scripts with inferred targets. Defaults to `true` when `NX_PCV3=true` and the package is a core Nx plugin
Update `package.json` scripts with inferred targets. Defaults to `true` when the package is a core Nx plugin

### verbose

Expand Down
34 changes: 1 addition & 33 deletions docs/generated/packages/nx/documents/init.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,36 +17,12 @@ Install `nx` globally to invoke the command directly using `nx`, or use `npx nx`

## Options

### addE2e

Type: `boolean`

Default: `false`

Set up Cypress E2E tests in integrated workspaces. Only for CRA projects.

### force

Type: `boolean`

Default: `false`

Force the migration to continue and ignore custom webpack setup or uncommitted changes. Only for CRA projects.

### help

Type: `boolean`

Show help

### integrated

Type: `boolean`

Default: `false`

Migrate to an Nx integrated layout workspace. Only for Angular CLI workspaces and CRA projects.

### interactive

Type: `boolean`
Expand All @@ -59,7 +35,7 @@ When false disables interactive input prompts for options.

Type: `boolean`

Set up remote caching with Nx Cloud.
Set up distributed caching with Nx Cloud.

### useDotNxInstallation

Expand All @@ -74,11 +50,3 @@ Initialize an Nx workspace setup in the .nx directory of the current repository.
Type: `boolean`

Show version number

### vite

Type: `boolean`

Default: `true`

Use Vite as the bundler. Only for CRA projects.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "configuration",
"factory": "./src/generators/configuration/configuration",
"factory": "./src/generators/configuration/configuration#configurationGeneratorInternal",
"schema": {
"$schema": "https://json-schema.org/schema",
"$id": "NxPlaywrightConfiguration",
Expand Down Expand Up @@ -74,7 +74,7 @@
"presets": []
},
"description": "Add Nx Playwright configuration to your project",
"implementation": "/packages/playwright/src/generators/configuration/configuration.ts",
"implementation": "/packages/playwright/src/generators/configuration/configuration#configurationGeneratorInternal.ts",
"aliases": [],
"hidden": false,
"path": "/packages/playwright/src/generators/configuration/schema.json",
Expand Down
4 changes: 2 additions & 2 deletions docs/generated/packages/playwright/generators/init.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "init",
"factory": "./src/generators/init/init",
"factory": "./src/generators/init/init#initGeneratorInternal",
"schema": {
"$schema": "https://json-schema.org/schema",
"$id": "NxPlaywrightInit",
Expand Down Expand Up @@ -37,7 +37,7 @@
"presets": []
},
"description": "Initializes a Playwright project in the current workspace",
"implementation": "/packages/playwright/src/generators/init/init.ts",
"implementation": "/packages/playwright/src/generators/init/init#initGeneratorInternal.ts",
"aliases": [],
"hidden": false,
"path": "/packages/playwright/src/generators/init/schema.json",
Expand Down
4 changes: 2 additions & 2 deletions docs/generated/packages/react-native/generators/init.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "init",
"factory": "./src/generators/init/init#reactNativeInitGenerator",
"factory": "./src/generators/init/init#reactNativeInitGeneratorInternal",
"schema": {
"cli": "nx",
"$id": "NxReactNativeInit",
Expand Down Expand Up @@ -39,7 +39,7 @@
},
"description": "Initialize the `@nx/react-native` plugin.",
"hidden": true,
"implementation": "/packages/react-native/src/generators/init/init#reactNativeInitGenerator.ts",
"implementation": "/packages/react-native/src/generators/init/init#reactNativeInitGeneratorInternal.ts",
"aliases": [],
"path": "/packages/react-native/src/generators/init/schema.json",
"type": "generator"
Expand Down
Loading