Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): enable project crystal by default #21403

Merged
merged 66 commits into from
Feb 2, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

NX_PCV3 must be set to true in order to get Project Crystal enabled.

Expected Behavior

Project Crystal is opt-out by setting NX_ADD_PLUGINS=false

Related Issue(s)

Fixes #

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 8:39am

@FrozenPandaz FrozenPandaz force-pushed the crystal-default branch 2 times, most recently from c9d4af6 to 73a121b Compare January 30, 2024 03:47
@FrozenPandaz FrozenPandaz force-pushed the crystal-default branch 2 times, most recently from 895b41b to 36cdbf2 Compare January 30, 2024 17:47
@FrozenPandaz FrozenPandaz force-pushed the crystal-default branch 2 times, most recently from 8aa4020 to 4228536 Compare January 31, 2024 04:45
@FrozenPandaz FrozenPandaz marked this pull request as ready for review February 2, 2024 08:40
@FrozenPandaz
Copy link
Collaborator Author

Most of the tests should be passing or disabled. I'm going to merge this so we can get a beta released. We will need to fix these failing tests asap.

@FrozenPandaz FrozenPandaz merged commit 396ffc4 into nrwl:master Feb 2, 2024
2 of 5 checks passed
Copy link

github-actions bot commented Feb 8, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants