fix(vite): PCV3 Plugin update to use resolveConfig

packages/vite/src/plugins/__snapshots__/plugin-with-test.spec.ts.snap

@@ -6,46 +6,6 @@ exports[`@nx/vite/plugin with test node root project should create nodes - with
     ".": {
       "root": ".",
       "targets": {
-        "build": {
-          "cache": true,
-          "command": "vite build",
-          "dependsOn": [
-            "^build",
-          ],
-          "inputs": [
-            "production",
-            "^production",
-            {
-              "externalDependencies": [
-                "vite",
-              ],
-            },
-          ],
-          "options": {
-            "cwd": ".",
-          },
-          "outputs": [
-            "{projectRoot}/dist",
-          ],
-        },
-        "preview": {
-          "command": "vite preview",
-          "options": {
-            "cwd": ".",
-          },
-        },
-        "serve": {
-          "command": "vite serve",
-          "options": {
-            "cwd": ".",
-          },
-        },
-        "serve-static": {
-          "executor": "@nx/web:file-server",
-          "options": {
-            "buildTarget": "build",
-          },
-        },
         "test": {
           "cache": true,
           "command": "vitest run",

packages/vite/src/plugins/plugin-vitest.spec.ts

@@ -2,7 +2,7 @@ import { CreateNodesContext } from '@nx/devkit';
 import { createNodes } from './plugin';
 
 jest.mock('vite', () => ({
-  loadConfigFromFile: jest.fn().mockImplementation(() => {
+  resolveConfig: jest.fn().mockImplementation(() => {
     return Promise.resolve({
       path: 'vitest.config.ts',
       config: {},
@@ -13,7 +13,7 @@ jest.mock('vite', () => ({
 
 jest.mock('../utils/executor-utils', () => ({
   loadViteDynamicImport: jest.fn().mockResolvedValue({
-    loadConfigFromFile: jest.fn().mockResolvedValue({
+    resolveConfig: jest.fn().mockResolvedValue({
       path: 'vitest.config.ts',
       config: {},
       dependencies: [],

packages/vite/src/plugins/plugin-with-test.spec.ts

@@ -1,14 +1,14 @@
 import { CreateNodesContext } from '@nx/devkit';
 import { createNodes } from './plugin';
 
+// This will only create test targets since no build targets are defined in vite.config.ts
+
 jest.mock('vite', () => ({
-  loadConfigFromFile: jest.fn().mockImplementation(() => {
+  resolveConfig: jest.fn().mockImplementation(() => {
     return Promise.resolve({
       path: 'vite.config.ts',
-      config: {
-        test: {
-          some: 'option',
-        },
+      test: {
+        some: 'option',
       },
       dependencies: [],
     });
@@ -17,12 +17,10 @@ jest.mock('vite', () => ({
 
 jest.mock('../utils/executor-utils', () => ({
   loadViteDynamicImport: jest.fn().mockResolvedValue({
-    loadConfigFromFile: jest.fn().mockResolvedValue({
+    resolveConfig: jest.fn().mockResolvedValue({
       path: 'vite.config.ts',
-      config: {
-        test: {
-          some: 'option',
-        },
+      test: {
+        some: 'option',
       },
       dependencies: [],
     }),

packages/vite/src/plugins/plugin.spec.ts

@@ -3,18 +3,19 @@ import { createNodes } from './plugin';
 import { TempFs } from 'nx/src/internal-testing-utils/temp-fs';
 
 jest.mock('vite', () => ({
-  loadConfigFromFile: jest.fn().mockImplementation(() => {
+  resolveConfig: jest.fn().mockImplementation(() => {
     return Promise.resolve({
       path: 'vite.config.ts',
       config: {},
+      build: {},
       dependencies: [],
     });
   }),
 }));
 
 jest.mock('../utils/executor-utils', () => ({
   loadViteDynamicImport: jest.fn().mockResolvedValue({
-    loadConfigFromFile: jest.fn().mockResolvedValue({
+    resolveConfig: jest.fn().mockResolvedValue({
       path: 'vite.config.ts',
       config: {},
       dependencies: [],
@@ -26,7 +27,9 @@ describe('@nx/vite/plugin', () => {
   let createNodesFunction = createNodes[1];
   let context: CreateNodesContext;
   describe('root project', () => {
+    let tempFs;
     beforeEach(async () => {
+      tempFs = new TempFs('');
       context = {
         nxJsonConfiguration: {
           // These defaults should be overridden by plugin
@@ -43,6 +46,7 @@ describe('@nx/vite/plugin', () => {
         },
         workspaceRoot: '',
       };
+      tempFs.createFileSync('index.html', '');
     });
 
     afterEach(() => {
@@ -67,8 +71,9 @@ describe('@nx/vite/plugin', () => {
   });
 
   describe('not root project', () => {
-    const tempFs = new TempFs('test');
+    let tempFs;
     beforeEach(() => {
+      tempFs = new TempFs('test');
       context = {
         nxJsonConfiguration: {
           namedInputs: {
@@ -84,6 +89,7 @@ describe('@nx/vite/plugin', () => {
         JSON.stringify({ name: 'my-app' })
       );
       tempFs.createFileSync('my-app/vite.config.ts', '');
+      tempFs.createFileSync('my-app/index.html', '');
     });
 
     afterEach(() => {

packages/vite/src/plugins/plugin.ts

@@ -92,26 +92,30 @@ async function buildViteTargets(
   options: VitePluginOptions,
   context: CreateNodesContext
 ) {
-  const { loadConfigFromFile } = await loadViteDynamicImport();
-  const viteConfig = await loadConfigFromFile(
+  const absoluteConfigFilePath = joinPathFragments(
+    context.workspaceRoot,
+    configFilePath
+  );
+  const { resolveConfig } = await loadViteDynamicImport();
+  const viteConfig = await resolveConfig(
     {
-      command: 'build',
-      mode: 'production',
+      configFile: absoluteConfigFilePath,
+      mode: 'development',
     },
-    configFilePath
+    'build'
   );
 
-  const { buildOutputs, testOutputs, hasTest } = getOutputs(
-    viteConfig?.config,
+  const { buildOutputs, testOutputs, hasTest, isBuildable } = getOutputs(
+    viteConfig,
     projectRoot
   );
 
   const namedInputs = getNamedInputs(projectRoot, context);
 
   const targets: Record<string, TargetConfiguration> = {};
 
-  // If file is not vitest.config, create targets for build, serve, preview and serve-static
-  if (!configFilePath.includes('vitest.config')) {
+  // If file is not vitest.config and buildable, create targets for build, serve, preview and serve-static
+  if (!configFilePath.includes('vitest.config') && isBuildable) {
     targets[options.buildTargetName] = await buildTarget(
       options.buildTargetName,
       namedInputs,
@@ -226,6 +230,7 @@ function getOutputs(
   buildOutputs: string[];
   testOutputs: string[];
   hasTest: boolean;
+  isBuildable: boolean;
 } {
   const { build, test } = viteConfig;
 
@@ -235,6 +240,11 @@ function getOutputs(
     'dist'
   );
 
+  const isBuildable =
+    build?.lib ||
+    build?.rollupOptions?.inputs ||
+    existsSync(join(workspaceRoot, projectRoot, 'index.html'));
+
   const reportsDirectoryPath = normalizeOutputPath(
     test?.coverage?.reportsDirectory,
     projectRoot,
@@ -245,6 +255,7 @@ function getOutputs(
     buildOutputs: [buildOutputPath],
     testOutputs: [reportsDirectoryPath],
     hasTest: !!test,
+    isBuildable,
   };
 }