fix(vite): PCV3 Plugin update to use resolveConfig

[ndcunningham]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Jan 25, 2024 8:08pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6e0c284. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --target=e2e --base=70fd808d9ca9daa5c7d0c596df9ffa79ab55d321 --head=6e0c28424723c27f2a445c56e23e7aa7edbcea8a --parallel=1
• nx affected --targets=lint,test,build --base=70fd808d9ca9daa5c7d0c596df9ffa79ab55d321 --head=6e0c28424723c27f2a445c56e23e7aa7edbcea8a --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=70fd808d9ca9daa5c7d0c596df9ffa79ab55d321 --head=6e0c28424723c27f2a445c56e23e7aa7edbcea8a
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=70fd808d9ca9daa5c7d0c596df9ffa79ab55d321 --head=6e0c28424723c27f2a445c56e23e7aa7edbcea8a

---

Sent with 💌 from NxCloud.

[FrozenPandaz]

Victor got this error when running with vite in CI:

~/p/t/p/test (main|✔) $ rm -rf node_modules/ pnpm-lock.yaml && CI=true pnpm i
Progress: resolved 1, reused 0, downloaded 0, added 0
Progress: resolved 33, reused 33, downloaded 0, added 0
Progress: resolved 89, reused 81, downloaded 0, added 0
Progress: resolved 317, reused 299, downloaded 0, added 0
Progress: resolved 701, reused 649, downloaded 1, added 0
Progress: resolved 1012, reused 960, downloaded 1, added 0
 WARN  2 deprecated subdependencies found: [email protected], [email protected]
Packages: +967
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 1017, reused 966, downloaded 1, added 967, done
.../[email protected]/node_modules/esbuild postinstall$ node install.js
.../[email protected]/node_modules/esbuild postinstall: Done
.../[email protected]/node_modules/cypress postinstall$ node index.js --exec install
.../[email protected]/node_modules/cypress postinstall: Cypress 13.6.3 is installed in /home/jason/.cache/Cypress/13.6.3
.../[email protected]/node_modules/cypress postinstall: Done
.../node_modules/nx postinstall$ node ./bin/post-install
.../node_modules/nx postinstall: The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
.../node_modules/nx postinstall: (node:46908) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
.../node_modules/nx postinstall: (Use `node --trace-deprecation ...` to show where the warning was created)
.../node_modules/nx postinstall: ✘ [ERROR] Could not resolve "/home/jason/projects/triage/pcv3/test/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]/node_modules/nx/apps/app1/vite.config.ts"
.../node_modules/nx postinstall: failed to load config from /home/jason/projects/triage/pcv3/test/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]/node_modules/nx/apps/app1/vite.config.ts
.../node_modules/nx postinstall: Unable to create nodes for apps/app1/vite.config.ts using plugin @nx/vite/plugin.
.../node_modules/nx postinstall: 	 Inner Error: Error: Build failed with 1 error:
.../node_modules/nx postinstall: error: Could not resolve "/home/jason/projects/triage/pcv3/test/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]/node_modules/nx/apps/app1/vite.config.ts"
.../node_modules/nx postinstall:     at failureErrorWithLog (/home/jason/projects/triage/pcv3/test/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1651:15)
.../node_modules/nx postinstall:     at /home/jason/projects/triage/pcv3/test/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1059:25
.../node_modules/nx postinstall:     at runOnEndCallbacks (/home/jason/projects/triage/pcv3/test/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1486:45)
.../node_modules/nx postinstall:     at buildResponseToResult (/home/jason/projects/triage/pcv3/test/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1057:7)
.../node_modules/nx postinstall:     at /home/jason/projects/triage/pcv3/test/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1086:16
.../node_modules/nx postinstall:     at responseCallbacks.<computed> (/home/jason/projects/triage/pcv3/test/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:704:9)
.../node_modules/nx postinstall:     at handleIncomingPacket (/home/jason/projects/triage/pcv3/test/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:764:9)
.../node_modules/nx postinstall:     at Socket.readFromStdout (/home/jason/projects/triage/pcv3/test/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:680:7)
.../node_modules/nx postinstall:     at Socket.emit (node:events:514:28)
.../node_modules/nx postinstall:     at addChunk (node:internal/streams/readable:545:12)
.../node_modules/nx postinstall:     at readableAddChunkPushByteMode (node:internal/streams/readable:495:3)
.../node_modules/nx postinstall:     at Socket.Readable.push (node:internal/streams/readable:375:5)
.../node_modules/nx postinstall:     at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)
.../node_modules/nx postinstall: Done

We can fix it by passing in the absolute path of the viteConfig. Can we sneak that into this PR please? 🙏

[jaysoo]

It's still not working for this repo https://github.com/jaysoo/vite-app-libs

I think once the config is resolved we still need to check the inputs to make sure they exist?

[ndcunningham]

It's still not working for this repo https://github.com/jaysoo/vite-app-libs

I think once the config is resolved we still need to check the inputs to make sure they exist?

There was a problem using resolveConfig looking through the vite code it merges other configs. So library configs would contain build after the resolve. Which is not expected?

Maybe we can look into that further, But moving forward, using loadConfigFromFile respects the config so we can determine if the config is buildable.

[jaysoo]

Qwik's config loads as

  path: '/Users/jack/projects/qwik-app/vite.config.ts',
  config: {
    plugins: [ [Array], [Object], [Object] ],
    server: { headers: [Object] },
    preview: { headers: [Object] }
  },
  dependencies: [ 'vite.config.ts' ]
}

We should get this to work because unlike Remix, Qwik expects users to run vite build, etc.

Example: https://app.warp.dev/block/xuT3vrlbiAmWrnHvoQK7TF

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.