Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): fixed isolatedConfig: false option not composing plugins #20678

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix(webpack): fixed isolatedConfig: false option not composing plugins #20678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/webpack/src/executors/webpack/webpack.impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import type {
} from './schema';
import { normalizeOptions } from './lib/normalize-options';
import {
composePlugins,
composePluginsSync,
isNxWebpackComposablePlugin,
} from '../../utils/config';
import { withNx } from '../../utils/with-nx';
Expand Down Expand Up @@ -54,7 +54,9 @@ async function getWebpackConfigs(

const config = options.isolatedConfig
? {}
: composePlugins(withNx(options), withWeb(options));
: (options.target === 'web'
jaysoo marked this conversation as resolved.
Show resolved Hide resolved
? composePluginsSync(withNx(options), withWeb(options))
: withNx(options))({}, { options, context });

if (isNxWebpackComposablePlugin(userDefinedWebpackConfig)) {
// Old behavior, call the Nx-specific webpack config function that user exports
Expand Down