fix(webpack): fixed isolatedConfig: false option not composing plugins

[TriPSs]

Current Behavior

When compiling a node project that has isolatedConfig set to false and does not provide an webpack config this error is thrown:

 >  NX   Invalid configuration object. Webpack has been initialized using a configuration object that does not match the API schema.

    - configuration has an unknown property 'nxWebpackComposablePlugin'. These properties are valid:
      object { amd?, bail?, cache?, context?, dependencies?, devServer?, devtool?, entry?, experiments?, extends?, externals?, externalsPresets?, externalsType?, ignoreWarnings?, infrastructureLogging?, loader?, mode?, module?, name?, node?, optimization?, output?, parallelism?, performance?, plugins?, profile?, recordsInputPath?, recordsOutputPath?, recordsPath?, resolve?, resolveLoader?, snapshot?, stats?, target?, watch?, watchOptions? }
      -> Options object as provided by the user.
      For typos: please correct them.
      For loader options: webpack >= v2.0.0 no longer allows custom properties in configuration.
        Loaders should be updated to allow passing options via loader options in module.rules.
        Until loaders are updated one can use the LoaderOptionsPlugin to pass these options to the loader:
        plugins: [
          new webpack.LoaderOptionsPlugin({
            // test: /\.xxx$/, // may apply this only for some modules
            options: {
              nxWebpackComposablePlugin: …
            }
          })
        ]
   Pass --verbose to see the stacktrace.

Expected Behavior

For the default plugins to be added correctly

Related Issue(s)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Dec 11, 2023 8:44pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1a63d15. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --target=e2e --base=dbeaf920423e91da5b8ef31450c524cb6d589a4b --head=1a63d151deea55e68b75bc0bc6bb17e92ae1e884 --parallel=1
• nx affected --targets=lint,test,build --base=dbeaf920423e91da5b8ef31450c524cb6d589a4b --head=1a63d151deea55e68b75bc0bc6bb17e92ae1e884 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=dbeaf920423e91da5b8ef31450c524cb6d589a4b --head=1a63d151deea55e68b75bc0bc6bb17e92ae1e884
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=dbeaf920423e91da5b8ef31450c524cb6d589a4b --head=1a63d151deea55e68b75bc0bc6bb17e92ae1e884

---

Sent with 💌 from NxCloud.

[TriPSs]

@JamesHenry I also noticed that with isolatedConfig set to false it now does withNx and withWeb, which causes issues for Node projects. This was not the case in the old implementation:

nx/packages/webpack/src/executors/webpack/lib/get-webpack-config.ts

Lines 22 to 25 in df252a6

	const configure =
	options.target === 'web'
	? composePluginsSync(withNx(), withWeb())
	: withNx();

Shall I re-add that method to this file to restore that logic?

[jaysoo]

@JamesHenry I also noticed that with isolatedConfig set to false it now does withNx and withWeb, which causes issues for Node projects. This was not the case in the old implementation:

nx/packages/webpack/src/executors/webpack/lib/get-webpack-config.ts

Lines 22 to 25 in df252a6

	const configure =
	options.target === 'web'
	? composePluginsSync(withNx(), withWeb())
	: withNx();

Shall I re-add that method to this file to restore that logic?

I'll add it an get it pushed through.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.