Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): update tsconfig included and excluded files when generating a library secondary entry point #19366

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Sep 28, 2023

Current Behavior

Generating a library secondary entry point doesn't update the tsconfig included and excluded file patterns.

Expected Behavior

Generating a library secondary entry point should update the relevant tsconfig included and excluded file patterns.

Related Issue(s)

Fixes #19038

@leosvelperez leosvelperez self-assigned this Sep 28, 2023
@leosvelperez leosvelperez requested a review from a team as a code owner September 28, 2023 09:48
@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2023 9:49am

@leosvelperez leosvelperez merged commit 0468627 into nrwl:master Sep 28, 2023
2 checks passed
@leosvelperez leosvelperez deleted the angular/secondary-entrypoints-update-tsconfig-include branch September 28, 2023 12:55
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

angular:library-secondary-entry-point doesn't update include
2 participants