Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angular:library-secondary-entry-point doesn't update include #19038

Closed
JeanMeche opened this issue Sep 6, 2023 · 1 comment · Fixed by #19366
Closed

angular:library-secondary-entry-point doesn't update include #19038

JeanMeche opened this issue Sep 6, 2023 · 1 comment · Fixed by #19366
Assignees
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug

Comments

@JeanMeche
Copy link

JeanMeche commented Sep 6, 2023

Current Behavior

In a nx monorepo :

Create a lib & a secondary entry:

  • nx g @nx/angular:library my-ui-lib --publishable --importPath @MyCorp/MyLib
  • nx g @nx/angular:library-secondary-entry-point --library=my-ui-lib --name=button

In tsconfig.lib.json: We have "include": ["src/**/*.ts"]

Expected Behavior

include should be migrated to "include": ["**/*.ts"] to include the secondary entry that we just created.

GitHub Repo

https://github.com/jeanmeche/nx-demo

Steps to Reproduce

Run nx g @nx/angular:library-secondary-entry-point --library=my-ui-lib --name=button on the repo.

Nx Report

Node   : 18.15.0
   OS     : darwin-x64
   npm    : 9.5.0
   
   nx (global)        : 16.7.4
   nx                 : 16.7.4
   @nx/js             : 16.7.4
   @nx/jest           : 16.7.4
   @nx/linter         : 16.7.4
   @nx/workspace      : 16.7.4
   @nx/angular        : 16.7.4
   @nx/cypress        : 16.7.4
   @nx/devkit         : 16.7.4
   @nx/eslint-plugin  : 16.7.4
   @nrwl/tao          : 16.7.4
   @nx/webpack        : 16.7.4
   typescript         : 5.1.6
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug
Projects
None yet
3 participants