Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): windows filePaths should be handled in findProjectForPath #17688

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jun 20, 2023

Current Behavior

Passing a windows file path to findProjectForPath errors out as Project Mappings are set up with UNIX style paths

Expected Behavior

Passing Unix or Win style file paths should still return correct project.

Related Issue(s)

Fixes nrwl/nx-labs#291

@Coly010 Coly010 requested a review from a team as a code owner June 20, 2023 11:23
@Coly010 Coly010 requested a review from FrozenPandaz June 20, 2023 11:23
@Coly010 Coly010 self-assigned this Jun 20, 2023
@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 11:25am

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remix app cannot be served on Windows
2 participants