feat(core): load environment variables from configuration name

[AgentEnder]

Adds support for loading environment variables from .env.[configurationName] and .[configurationName].env

Fixes: #17686

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 21, 2023 10:39pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1dd261d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx affected -t e2e-macos --parallel=1 --base=6dd652095c07cf26635b5e583249b0bdaa400902 --head=1dd261da053c2e9318674f7a435c4936fb3f4fd7

---

Sent with 💌 from NxCloud.

[SmoshySmosh]

This solution does not provide the proper documentation and it is not clear how to use it without having deeper knowledge of the internals of NX.

I originally explored this as a quick and easy solution but I quickly realized it was untenable due to the synchronization overhead it would add to a mono repo of any size. This change requires a re-definition of every configuration in every target of every package in your mono repo, which you then need to keep in sync as you add new packages. We should think through this problem a little more and find a solution that both decreases the complexity of NX and serves the need of NX's customers.

For example, this is what every target will have to become to support .beta.env, .gamma.env, and .prod.env

"targets: {
  ...,
  "e2e": {
    ...
    "configurations": {
      "beta": {},
      "gamma": {},
      "prod": {},
    }
  }
}

[AgentEnder]

This change requires a re-definition of every configuration in every target of every package in your mono repo, which you then need to keep in sync as you add new packages

Hey @SmoshySmosh. I appreciate you looking over the PR, it does also include a piece that allows Nx to infer configurations from the availability of the relevant .env files, so I think it should cover the use cases you mention.

[FrozenPandaz]

I don't think having a file there should define a configuration. Configurations should still be defined in the project configuration. If we'd like an easier way to define configurations, that is a separate discussion.

Can we remove this part from the changes here and consider them separately?

[SmoshySmosh]

I don't think having a file there should define a configuration. Configurations should still be defined in the project configuration. If we'd like an easier way to define configurations, that is a separate discussion.

Removing the requirement to redefine a configuration under every target is what myself and other customers are trying to get. With the current state of environment files in NX, a great deal of technical debt and configuration overhead is generated making it an unusable solution for most projects ultimately making NX very limiting.

[FrozenPandaz]

Were you going to do something with this?

[AgentEnder]

I was, yes. It looks like the e2e I had added somehow got lost 🤔

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.