chore(core): address pr feedback

nrwl · Jun 21, 2023 · e0a6496 · e0a6496
1 parent e577641
commit e0a6496
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 24 deletions.
diff --git a/e2e/nx-run/src/run.test.ts b/e2e/nx-run/src/run.test.ts
@@ -198,6 +198,15 @@ describe('Nx Running Tests', () => {
           scripts: {
             [target]: `echo ${expectedOutput}`,
           },
+          nx: {
+            targets: {
+              [target]: {
+                configurations: {
+                  production: {},
+                },
+              },
+            },
+          },
         })
       );
 

diff --git a/packages/nx/src/utils/project-graph-utils.ts b/packages/nx/src/utils/project-graph-utils.ts
@@ -1,10 +1,9 @@
 import { buildTargetFromScript, PackageJson } from './package-json';
 import { join } from 'path';
 import { ProjectGraph, ProjectGraphProjectNode } from '../config/project-graph';
-import { fileExists, readJsonFile } from './fileutils';
+import { readJsonFile } from './fileutils';
 import { readCachedProjectGraph } from '../project-graph/project-graph';
 import { TargetConfiguration } from '../config/workspace-json-project-json';
-import { workspaceRoot } from './workspace-root';
 
 export function projectHasTarget(
   project: ProjectGraphProjectNode,
@@ -23,28 +22,9 @@ export function projectHasTargetAndConfiguration(
   configuration: string
 ) {
   return (
-    // Explicitly defined target + configuration
-    (projectHasTarget(project, target) &&
-      project.data.targets[target].configurations &&
-      project.data.targets[target].configurations[configuration]) ||
-    // Inferred configuration from presence of .env files
-    (projectHasTarget(project, target) &&
-      [
-        join(workspaceRoot, `.env.${configuration}`),
-        join(workspaceRoot, `.${configuration}.env`),
-        join(workspaceRoot, project.data.root, `.env.${configuration}`),
-        join(workspaceRoot, project.data.root, `.${configuration}.env`),
-        join(
-          workspaceRoot,
-          project.data.root,
-          `.env.${target}.${configuration}`
-        ),
-        join(
-          workspaceRoot,
-          project.data.root,
-          `.${target}.${configuration}.env`
-        ),
-      ].some(fileExists))
+    projectHasTarget(project, target) &&
+    project.data.targets[target].configurations &&
+    project.data.targets[target].configurations[configuration]
   );
 }