Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devkit): uppercase constant name correct transformation #17046

Merged
merged 1 commit into from
May 16, 2023

Conversation

mandarini
Copy link
Member

closed #12681

Current Behavior

As described in linked issue, CONSTANT_NAME would be transformed to C_ONSTANTNAME

Expected Behavior

CONSTANT_NAME is kept as is.

Related Issue(s)

Fixes #12681

@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 10:11am

@mandarini mandarini self-assigned this May 16, 2023
@AgentEnder AgentEnder merged commit 9866595 into nrwl:master May 16, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/devkit names function incorrectly converts PascalName to CONSTANT_NAME
2 participants