fix(devkit): uppercase constant name correct transformation (#17046)

nrwl · May 16, 2023 · 9866595 · 9866595 · vercel · May 16, 2023
1 parent 88b263b
commit 9866595
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/devkit/src/utils/names.spec.ts b/packages/devkit/src/utils/names.spec.ts
@@ -47,5 +47,6 @@ describe('names', () => {
     expect(names('foo-@bar').constantName).toEqual('FOO_BAR');
     expect(names(' foo bar').constantName).toEqual('FOO_BAR');
     expect(names('_foo_bar').constantName).toEqual('FOO_BAR');
+    expect(names('FOO_BAR').constantName).toEqual('FOO_BAR');
   });
 });
diff --git a/packages/devkit/src/utils/names.ts b/packages/devkit/src/utils/names.ts
@@ -48,7 +48,8 @@ function toPropertyName(s: string): string {
  * Hyphenated to CONSTANT_CASE
  */
 function toConstantName(s: string): string {
-  return toFileName(toPropertyName(s))
+  const normalizedS = s.toUpperCase() === s ? s.toLowerCase() : s;
+  return toFileName(toPropertyName(normalizedS))
     .replace(/([^a-zA-Z0-9])/g, '_')
     .toUpperCase();
 }