fix(nextjs): error caused by undefined 'serverActions' #16846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This commit addresses a bug introduced in the PR nrwl#16819, which caused a TypeError when running NextJS 13.4 with the '_nextConfig.experimental' object missing the 'serverActions' property. The fix involves adding checks to ensure that both the '_nextConfig.experimental' object and 'serverActions' property are defined before attempting to access them. If 'serverActions' is undefined, the code defaults to using 'next'. closed 16845
ruslanguns
force-pushed
the
16845-fix-issue-with-serveractions
branch
from
205ae24 to
d6bfeb9
Compare
|
same issue.. |
xiongemi
reviewed
May 11, 2023
| _nextConfig.experimental['serverActions'] ? 'experimental' : 'next'; | ||
| _nextConfig.experimental && _nextConfig.experimental['serverActions'] | ||
| ? 'experimental' | ||
| : 'next'; |
There was a problem hiding this comment.
i think it could be just _nextConfig.experimental?.['serverActions'] ? 'experimental' : 'next'
|
Thanks for the PR, we appreciate the contribution. I did not see this PR before landing this patch here #16909. |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
This PR addresses a bug introduced in the PR #16819, which caused a TypeError when running NextJS 13.4 with the '_nextConfig.experimental' object missing the 'serverActions' property.
Expected Behavior
The fix involves adding checks to ensure that both the '_nextConfig.experimental' object and 'serverActions' property are defined before attempting to access them. If 'serverActions' is undefined, the code defaults to using 'next'.
Related Issue(s)
Fixes #16845