fix(nextjs): enable Next.js 13.4 support #16819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ndcunningham
approved these changes
May 5, 2023
ruslanguns
reviewed
May 6, 2023
| forNextVersion('>=13.4.0', () => { | ||
| process.env['__NEXT_PRIVATE_PREBUNDLED_REACT'] = | ||
| // Not in Next 13.3 or earlier, so need to access config via string | ||
| _nextConfig.experimental['serverActions'] ? 'experimental' : 'next'; |
There was a problem hiding this comment.
@jaysoo If serverActions is not specified on the experimental object, then it will throw an error because of undefined.
There was a problem hiding this comment.
Yes, I had the same error as @ruslanguns. It should be first checked if experimental object exists in the config, something like _nextConfig.experimental && _nextConfig.experimental['serverActions']
4 tasks
ruslanguns
added a commit
to ruslanguns/nx
that referenced
this pull request
May 7, 2023
This commit addresses a bug introduced in the PR nrwl#16819, which caused a TypeError when running NextJS 13.4 with the '_nextConfig.experimental' object missing the 'serverActions' property. The fix involves adding checks to ensure that both the '_nextConfig.experimental' object and 'serverActions' property are defined before attempting to access them. If 'serverActions' is undefined, the code defaults to using 'next'. closed 16845
ruslanguns
added a commit
to ruslanguns/nx
that referenced
this pull request
May 8, 2023
This commit addresses a bug introduced in the PR nrwl#16819, which caused a TypeError when running NextJS 13.4 with the '_nextConfig.experimental' object missing the 'serverActions' property. The fix involves adding checks to ensure that both the '_nextConfig.experimental' object and 'serverActions' property are defined before attempting to access them. If 'serverActions' is undefined, the code defaults to using 'next'. closed 16845
|
it seems #15796 is still an issue when enabling app directory |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a missing environment variable needed to override
reactandreact-domto use the once bundled into Next.js itself. Note: This will not be needed once we invoke Next.js CLI directly.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #16692