feat(react): refactor util getModuleFederationConfig to avoid to pass function to determinate the remote url

[fyodorovandrei]

Current Behavior

For the utils getModuleFederationConfig you need to pass the parameter determineRemoteUrl.

Expected Behavior

For the util getModuleFederationConfig now no more needs to pass determineRemoteUrl. The util by itself understands which function to call

---

I open a PR in the Module Federation repository to add supports Module Federation remote containers in Storybook. To consume remote MF apps/components in Storybook I created a new util withModuleFederation to replace the existing NX util. In the new util I'm using getModuleFederationConfig. With this PR we can use util getModuleFederationConfig without passing the parameter determineRemoteUrl

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 27, 2023 10:54am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 72fbdf1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx affected -t e2e-macos --parallel=1 --base= --head=
• nx affected --target=e2e --base=19e34df1cd3e286cacc9e73781cbb8fbbcd6fc69 --head=72fbdf10431fbab51caf151f8f85c4ffa8d5dd81 --parallel=1
• nx affected --target=test --base=19e34df1cd3e286cacc9e73781cbb8fbbcd6fc69 --head=72fbdf10431fbab51caf151f8f85c4ffa8d5dd81 --parallel=1
• nx affected --target=build --base=19e34df1cd3e286cacc9e73781cbb8fbbcd6fc69 --head=72fbdf10431fbab51caf151f8f85c4ffa8d5dd81 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx affected --target=lint --base=19e34df1cd3e286cacc9e73781cbb8fbbcd6fc69 --head=72fbdf10431fbab51caf151f8f85c4ffa8d5dd81 --parallel=3
• nx-cloud record -- nx format:check --base=19e34df1cd3e286cacc9e73781cbb8fbbcd6fc69 --head=72fbdf10431fbab51caf151f8f85c4ffa8d5dd81
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[fyodorovandrei]

@Coly010 You know more about :) If you have time to take a look will be nice. Thx 👍

[jaysoo]

Hey @fyodorovandrei Thanks for the PR. I'll discuss with @Coly010 about this PR, it looks reasonable to me. We do have the Nx 16 release this week, so we will be delayed in reviewing feature PRs.

One behavior change is that getModuleFederationConfig will now be tied to project configuration, which perhaps isn't a big deal since mostly encapsulate it within withModuleFederation util. Alternatively we could provide a default function rather than remove it completely.

[brunos3d]

What about using/creating a similar function to the findNextAvailablePort to prevent local port collisions?

[fyodorovandrei]

@Coly010 Why is a lot of duplicated code? Will be a good idea to refactor?

[Coly010]

There's no good common place that can be used here and there minor differences between react and angular that need to be accounted for. This is fine as is now

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.