feat(storybook-addon): refactor util withModuleFederation
#829
Conversation
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| @@ -10,6 +10,8 @@ | |||
|
|
|||
| [module-federation/typescript](./packages/typescript) | |||
|
|
|||
| [module-federation/storybook-addon](./packages/storybook-addon) | |||
|
|
|||
| ## Generate an application | |||
|
|
|||
| Run `nx g @nrwl/next:app my-app` to generate an application. | |||
There was a problem hiding this comment.
It seems that this is not actually code but rather a markdown document, likely related to a project's documentation or readme file.
As for the content itself, it looks like a brief introduction to a project, specifically mentioning its use of Nx and Next.js. There is also a note about generating an application using the nx g command.
Without additional context, it is difficult to provide specific feedback or improvements. However, listing out the changes made in the code patch would be helpful in understanding any potential risks or opportunities for improvement.
| @@ -122,7 +121,7 @@ | |||
| "merge-stream": "~2.0", | |||
| "ngx-deploy-npm": "^5.0.0", | |||
| "nodejieba": "^2.6.0", | |||
| "nx": "15.9.2", | |||
| "nx": "16.0.0", | |||
| "postcss-calc": "~8.2.0", | |||
| "postcss-custom-properties": "~13.1.0", | |||
| "postcss-import": "~15.1.0", | |||
There was a problem hiding this comment.
The code patch appears to be a dependency update in the package.json file. It updates various @nrwl packages and the nx package to version 16.0.0. There are no apparent syntax or logic issues in the code patch, and it seems to be a routine package update. However, it is always recommended to test thoroughly after updating dependencies to ensure compatibility and stability.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@module-federation/storybook-addon", | |||
| "version": "0.1.0", | |||
| "version": "0.1.1", | |||
| "description": "Storybook addon to consume remote module federated apps/components", | |||
| "license": "MIT", | |||
| "repository": "https://github.com/module-federation/universe/tree/main/packages/storybook-addon", | |||
There was a problem hiding this comment.
This is not a code patch, but rather a patch file containing changes to a package.json file.
The only change in this patch is the version number, which has been updated from "0.1.0" to "0.1.1". There are no bug risks associated with this change and it is a common practice to update the version number when making changes to a package.
Improvement suggestions would depend on the context of this package and its usage, but without more information, it is difficult to provide specific suggestions.
There was a problem hiding this comment.
my release system automatically incrementes package versions
|
Y@rn again. Lockfile is out of date |
fyodorovandrei
deleted the
features/refactor-with-module-federation-util
branch
I opened a PR in NX repo to avoid passing a function to determinate the remote URL
for util
getModuleFederationConfig. The PR is merged and now we can refactor utilwithModuleFederation.