fix(angular): build plugin runtime code with ts module option set to esnext #16448
+20
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The runtime code in the Angular plugin is built with
"module": "commonjs"
. This is producing a wrong output for the plugin.Expected Behavior
The runtime code in the Angular plugin is built with
"module": "esnext"
.Some context:
Before the runtime code was built running:
This was ignoring the tsconfig and using some defaults from
ng-packagr
. With the rescope, we now build the plugin using the@nx/angular:package
executor using thetsconfig.lib.json
settings for the build. There are differences in settings for the tooling code and the runtime code, so we build each with its own config.Related Issue(s)
Fixes #