Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): build plugin runtime code with ts module option set to esnext #16448

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Apr 20, 2023

Current Behavior

The runtime code in the Angular plugin is built with "module": "commonjs". This is producing a wrong output for the plugin.

Expected Behavior

The runtime code in the Angular plugin is built with "module": "esnext".

Some context:

Before the runtime code was built running:

npx ng-packagr -p packages/angular/ng-package.json

This was ignoring the tsconfig and using some defaults from ng-packagr. With the rescope, we now build the plugin using the @nx/angular:package executor using the tsconfig.lib.json settings for the build. There are differences in settings for the tooling code and the runtime code, so we build each with its own config.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Apr 20, 2023
@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 20, 2023 8:43pm

@leosvelperez leosvelperez changed the title fix(angular): build runtime code targeting esnext fix(angular): build plugin runtime code with ts module option set to esnext Apr 20, 2023
@leosvelperez leosvelperez force-pushed the angular/fix-package-build branch from 952c5e0 to 53e8a57 Compare April 20, 2023 20:42
@leosvelperez leosvelperez marked this pull request as ready for review April 20, 2023 20:43
@FrozenPandaz FrozenPandaz merged commit 258cda3 into nrwl:master Apr 21, 2023
@leosvelperez leosvelperez deleted the angular/fix-package-build branch April 21, 2023 14:56
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants