Skip to content

Commit

Permalink
fix(angular): build plugin runtime code with ts module option set to …
Browse files Browse the repository at this point in the history
…esnext (#16448)
  • Loading branch information
leosvelperez authored Apr 21, 2023
1 parent 425124f commit 258cda3
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 8 deletions.
2 changes: 1 addition & 1 deletion packages-legacy/angular/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"executor": "@nx/angular:package",
"options": {
"project": "packages-legacy/angular/ng-package.json",
"tsConfig": "packages-legacy/angular/tsconfig.json"
"tsConfig": "packages-legacy/angular/tsconfig.runtime.json"
},
"outputs": ["build/packages/angular-legacy"]
},
Expand Down
3 changes: 0 additions & 3 deletions packages-legacy/angular/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
{
"extends": "../../tsconfig.base.json",
"angularCompilerOptions": {
"compilationMode": "partial"
},
"include": ["**/*.ts"],
"files": ["index.ts"]
}
9 changes: 9 additions & 0 deletions packages-legacy/angular/tsconfig.runtime.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
"module": "esnext"
},
"angularCompilerOptions": {
"compilationMode": "partial"
}
}
2 changes: 1 addition & 1 deletion packages/angular/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"executor": "@nx/angular:package",
"options": {
"project": "packages/angular/ng-package.json",
"tsConfig": "packages/angular/tsconfig.lib.json"
"tsConfig": "packages/angular/tsconfig.lib.runtime.json"
},
"outputs": ["build/packages/angular"]
},
Expand Down
3 changes: 0 additions & 3 deletions packages/angular/tsconfig.lib.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
"declaration": true,
"types": ["node"]
},
"angularCompilerOptions": {
"compilationMode": "partial"
},
"exclude": [
"**/*.spec.ts",
"**/*.test.ts",
Expand Down
9 changes: 9 additions & 0 deletions packages/angular/tsconfig.lib.runtime.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"extends": "./tsconfig.lib.json",
"compilerOptions": {
"module": "esnext"
},
"angularCompilerOptions": {
"compilationMode": "partial"
}
}

0 comments on commit 258cda3

Please sign in to comment.