feat(core): error when a project graph plugin fails #16095
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
force-pushed
the
chore/throw-error-instead-of-warn-for-plugins
branch
from
d4ddef3 to
7f83525
Compare
| logger.warn(message); | ||
| logger.warn(`Run with NX_VERBOSE_LOGGING=true to see the error.`); | ||
| } | ||
| const message = `Failed to process the project graph with "${plugin.name}".`; |
There was a problem hiding this comment.
Do you think we should just throw the real error? People can see from the stacktrace where it is from right?
There was a problem hiding this comment.
I like having this line in here - the stack trace may show something like "Unable to read property X from undefined" and I can see folks opening that issue up here when its from a comm. plugin.
Putting the plugin name front and center should make it more likely that those issues don't start on our repo. I do think we should show the e.message too though - I'll get that updated.
AgentEnder
force-pushed
the
chore/throw-error-instead-of-warn-for-plugins
branch
from
7f83525 to
0d3fe0b
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
We warn when a project graph throws - this can hide logs and leave the repository in a confusing state.
Expected Behavior
We throw when a project graph plugin throws - this prevents the repository from ending up in a half-baked state.
Related Issue(s)
Fixes #