Skip to content

Commit

Permalink
chore(core): error when a project graph plugin fails
Browse files Browse the repository at this point in the history
  • Loading branch information
AgentEnder committed Apr 5, 2023
1 parent ee1f7c1 commit 0d3fe0b
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions packages/nx/src/project-graph/build-project-graph.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import {
} from '../config/project-graph';
import { readJsonFile } from '../utils/fileutils';
import { NxJsonConfiguration } from '../config/nx-json';
import { logger } from '../utils/logger';
import { ProjectGraphBuilder } from './project-graph-builder';
import {
ProjectConfiguration,
Expand Down Expand Up @@ -235,15 +234,12 @@ async function updateProjectGraphWithPlugins(
try {
graph = await plugin.processProjectGraph(graph, context);
} catch (e) {
const message = `Failed to process the project graph with "${plugin.name}". This will error in the future!`;
if (process.env.NX_VERBOSE_LOGGING === 'true') {
console.error(e);
logger.error(message);
return graph;
} else {
logger.warn(message);
logger.warn(`Run with NX_VERBOSE_LOGGING=true to see the error.`);
let message = `Failed to process the project graph with "${plugin.name}".`;
if (e instanceof Error) {
e.message = message + '\n' + e.message;
throw e;
}
throw new Error(message);
}
}
return graph;
Expand Down

0 comments on commit 0d3fe0b

Please sign in to comment.