fix(core): ensurePackage fails on pnpm workspaces #16002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeroslav
requested review from
FrozenPandaz,
vsavkin and
AgentEnder
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
meeroslav
force-pushed
the
optimize-workspace-create-tests
branch
2 times, most recently
from
db46661 to
7464280
Compare
meeroslav
commented
Mar 31, 2023
| @@ -158,8 +160,8 @@ export function getPackageManagerCommand({ | |||
| runUninstalledPackage: 'pnpm dlx', | |||
| install: 'pnpm i', | |||
| ciInstall: 'pnpm install --frozen-lockfile', | |||
| addProd: `pnpm add`, | |||
| addDev: `pnpm add -D`, | |||
| addProd: isPnpmWorkspace ? 'pnpm add -w' : 'pnpm add', | |||
There was a problem hiding this comment.
This was strangely broken the whole time
meeroslav
commented
Mar 31, 2023
| }); | ||
| }); | ||
|
|
||
| afterEach(() => cleanupProject()); | ||
| beforeEach(() => { | ||
| runCommand(`git reset --hard`); |
There was a problem hiding this comment.
We use git reset to revert all the changes done on the repo
meeroslav
force-pushed
the
optimize-workspace-create-tests
branch
from
7464280 to
c415852
Compare
meeroslav
force-pushed
the
optimize-workspace-create-tests
branch
2 times, most recently
from
aed5f8e to
9a0db05
Compare
mandarini
approved these changes
Apr 3, 2023
meeroslav
force-pushed
the
optimize-workspace-create-tests
branch
from
9a0db05 to
1aef7b9
Compare
meeroslav
commented
Apr 3, 2023
| }, | ||
| moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx', 'html'], | ||
| maxWorkers: 1, | ||
| globals: { 'ts-jest': { tsconfig: '<rootDir>/tsconfig.spec.json' } }, | ||
| globals: {}, |
There was a problem hiding this comment.
Usage of ts-jest in globals is deprecated
There was a problem hiding this comment.
strange that didn't get migrated 🤔
meeroslav
force-pushed
the
optimize-workspace-create-tests
branch
5 times, most recently
from
fb0a11b to
90fd0c4
Compare
|
Converting back to draft until |
meeroslav
commented
Apr 3, 2023
| const isVerbose = process.env.NX_VERBOSE_LOGGING === 'true'; | ||
| execSync( | ||
| `${ | ||
| getPackageManagerCommand(detectPackageManager(), tempDir).addDev |
There was a problem hiding this comment.
In the case of pnpm workspace, it would try to run the pnpm add -Dw ... command, which fails since tempDir is not a workspace.
meeroslav
changed the title
meeroslav
force-pushed
the
optimize-workspace-create-tests
branch
2 times, most recently
from
3c56cc3 to
48b08a1
Compare
meeroslav
force-pushed
the
optimize-workspace-create-tests
branch
5 times, most recently
from
d31ffd9 to
381f049
Compare
meeroslav
force-pushed
the
optimize-workspace-create-tests
branch
from
381f049 to
e4b9cc9
Compare
meeroslav
force-pushed
the
optimize-workspace-create-tests
branch
from
e4b9cc9 to
d330fa6
Compare
meeroslav
force-pushed
the
optimize-workspace-create-tests
branch
from
d330fa6 to
ff14335
Compare
AgentEnder
approved these changes
Apr 4, 2023
FrozenPandaz
approved these changes
Apr 6, 2023
| afterEach(() => cleanupProject()); | ||
| afterEach(() => { | ||
| runCommand(`git reset --hard HEAD`); | ||
| runCommand(`git clean -fdx`); |
There was a problem hiding this comment.
You don't need x here. x will clean out even gitignore'd files like node_modules which will slow down the install.
FrozenPandaz
pushed a commit
that referenced
this pull request
Apr 11, 2023
(cherry picked from commit b3a3f2a)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
ensurePackageonpnpmworkspacesensurePackagegetPackageManagerCommandto acceptrootas a second parameter-win thee2eutilse2e-create-nx-workspace-npmto use selected package managere2e-create-nx-workspace-npmto re-use the same workspaceCurrent Behavior
The
ensurePackagefails onpnpmworkspaceExpected Behavior
The
ensurePackagepasses onpnpmworkspace and installs the package as expected.Related Issue(s)
Fixes #