Skip to content

Commit

Permalink
fix(core): replace empty preset with apps
Browse files Browse the repository at this point in the history
  • Loading branch information
meeroslav committed Mar 31, 2023
1 parent 5300762 commit db46661
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion e2e/utils/create-project-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export function newProject({

if (!directoryExists(tmpBackupProjPath())) {
runCreateWorkspace(projScope, {
preset: 'empty',
preset: 'apps',
packageManager,
});

Expand Down
18 changes: 9 additions & 9 deletions e2e/workspace-create/src/create-nx-workspace.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ describe('create-nx-workspace', () => {
it('should be able to create an empty workspace built for apps', () => {
const wsName = uniq('apps');
runCreateWorkspace(wsName, {
preset: 'empty',
preset: 'apps',
packageManager,
});

Expand Down Expand Up @@ -273,7 +273,7 @@ describe('create-nx-workspace', () => {
it('should be able to create a workspace with a custom base branch and HEAD', () => {
const wsName = uniq('branch');
runCreateWorkspace(wsName, {
preset: 'empty',
preset: 'apps',
base: 'main',
packageManager,
});
Expand All @@ -282,7 +282,7 @@ describe('create-nx-workspace', () => {
it('should be able to create a workspace with custom commit information', () => {
const wsName = uniq('branch');
runCreateWorkspace(wsName, {
preset: 'empty',
preset: 'apps',
extraArgs:
'--commit.name="John Doe" --commit.email="[email protected]" --commit.message="Custom commit message!"',
packageManager,
Expand All @@ -307,8 +307,8 @@ describe('create-nx-workspace', () => {
process.env.SELECTED_PM = 'npm';

runCreateWorkspace(wsName, {
preset: 'empty',
packageManager,
preset: 'apps',
packageManager: 'npm',
});

checkFilesDoNotExist('yarn.lock');
Expand All @@ -320,7 +320,7 @@ describe('create-nx-workspace', () => {
it('should return error when ci workflow is selected but no cloud is set up', () => {
const wsName = uniq('github');
runCreateWorkspace(wsName, {
preset: 'empty',
preset: 'apps',
packageManager,
ci: 'circleci',
});
Expand All @@ -332,7 +332,7 @@ describe('create-nx-workspace', () => {
function setupProject(envPm: 'npm' | 'yarn' | 'pnpm') {
process.env.SELECTED_PM = envPm;
runCreateWorkspace(uniq('pm'), {
preset: 'empty',
preset: 'apps',
packageManager: envPm,
useDetectedPm: true,
});
Expand Down Expand Up @@ -379,7 +379,7 @@ describe('create-nx-workspace', () => {

describe('create-nx-workspace custom parent folder', () => {
const tmpDir = `${e2eCwd}/${uniq('with space')}`;
const wsName = uniq('empty');
const wsName = uniq('parent');
const packageManager = getSelectedPackageManager() || 'pnpm';

afterEach(() => cleanupProject({ cwd: `${tmpDir}/${wsName}` }));
Expand All @@ -388,7 +388,7 @@ describe('create-nx-workspace custom parent folder', () => {
mkdirSync(tmpDir, { recursive: true });

runCreateWorkspace(wsName, {
preset: 'empty',
preset: 'apps',
packageManager,
cwd: tmpDir,
});
Expand Down

0 comments on commit db46661

Please sign in to comment.