Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): fix the options for the builders #14279

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Jan 11, 2023

Change the target options for the Storybook executors (storybook and build-storybook).

The reason is to remove any extra "mappings" that we were doing. There's really no need to have any option named differently in Nx. Maybe some things were kept named differently to support some legacy ways of doing things, but this is not needed any more. Now both storybook and build-storybook executors accept the CLIOptions from Storybook , along with the uiFramework, to work for Nx. That may not even be needed when we only do Storybook 7.

Through the schema.json we are exposing most of the CLIOptions, but the user can pass all the available CLIOptions, and Nx will pass them down to the Storybook builder, since we set additionalProperties: true.

Some options that are not needed were also removed, like mode.

@vercel
Copy link

vercel bot commented Jan 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Jan 12, 2023 at 1:14PM (UTC)

@mandarini mandarini force-pushed the feat/refactor-options-sb-7 branch from d8653cc to 3ab8bb8 Compare January 11, 2023 17:17
@mandarini mandarini force-pushed the feat/refactor-options-sb-7 branch 2 times, most recently from b4f6e23 to 9349c61 Compare January 11, 2023 17:47
@mandarini mandarini force-pushed the feat/refactor-options-sb-7 branch 6 times, most recently from a4af3f7 to c45a4cb Compare January 12, 2023 11:14
@mandarini mandarini force-pushed the feat/refactor-options-sb-7 branch from c45a4cb to 0533366 Compare January 12, 2023 11:23
@mandarini mandarini changed the title WIP: executor options feat(storybook): fix the options for the builders Jan 12, 2023
@mandarini mandarini marked this pull request as ready for review January 12, 2023 11:51
@mandarini mandarini self-assigned this Jan 12, 2023
@mandarini mandarini force-pushed the feat/refactor-options-sb-7 branch from 0533366 to 16d23e5 Compare January 12, 2023 12:39
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants