-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storybook): fix the options for the builders #14279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mandarini
force-pushed
the
feat/refactor-options-sb-7
branch
from
January 11, 2023 17:17
d8653cc
to
3ab8bb8
Compare
mandarini
force-pushed
the
feat/refactor-options-sb-7
branch
2 times, most recently
from
January 11, 2023 17:47
b4f6e23
to
9349c61
Compare
mandarini
force-pushed
the
feat/refactor-options-sb-7
branch
6 times, most recently
from
January 12, 2023 11:14
a4af3f7
to
c45a4cb
Compare
mandarini
force-pushed
the
feat/refactor-options-sb-7
branch
from
January 12, 2023 11:23
c45a4cb
to
0533366
Compare
mandarini
changed the title
WIP: executor options
feat(storybook): fix the options for the builders
Jan 12, 2023
mandarini
force-pushed
the
feat/refactor-options-sb-7
branch
from
January 12, 2023 12:39
0533366
to
16d23e5
Compare
Coly010
approved these changes
Jan 12, 2023
mandarini
force-pushed
the
feat/refactor-options-sb-7
branch
from
January 12, 2023 13:10
16d23e5
to
406424f
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the target options for the Storybook executors (
storybook
andbuild-storybook
).The reason is to remove any extra "mappings" that we were doing. There's really no need to have any option named differently in Nx. Maybe some things were kept named differently to support some legacy ways of doing things, but this is not needed any more. Now both
storybook
andbuild-storybook
executors accept theCLIOptions
from Storybook , along with theuiFramework
, to work for Nx. That may not even be needed when we only do Storybook 7.Through the
schema.json
we are exposing most of theCLIOptions
, but the user can pass all the availableCLIOptions
, and Nx will pass them down to the Storybook builder, since we setadditionalProperties: true
.Some options that are not needed were also removed, like
mode
.