-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storybook): version 7 executors #14255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mandarini
force-pushed
the
feat/storybook-7-builders
branch
2 times, most recently
from
January 10, 2023 17:17
32411e8
to
05abb89
Compare
jaysoo
reviewed
Jan 10, 2023
packages/storybook/src/executors/build-storybook/build-storybook.impl.ts
Outdated
Show resolved
Hide resolved
mandarini
force-pushed
the
feat/storybook-7-builders
branch
4 times, most recently
from
January 11, 2023 15:04
20fa71b
to
b08cb9b
Compare
mandarini
force-pushed
the
feat/storybook-7-builders
branch
from
January 11, 2023 15:33
b08cb9b
to
5dbc264
Compare
jaysoo
approved these changes
Jan 11, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust Storybook executors to work with Storybook version 7
Findings
build-storybook
storybook
- it failsNext steps
CLIOptions
Note
This is part of a general effort to support Storybook 7. The effort will include a number of changes on Nx, like new generators, migrators, etc. This is the first addition in a series of many, to support the v7 Storybook builders through our executors.
Storybook 7 PRs