Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): version 7 executors #14255

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Jan 10, 2023

Adjust Storybook executors to work with Storybook version 7

Findings

  • Previous versions continue to work uninterrupted, as they did (eg. all Storybook v6.5 workspaces)
  • Workspaces with Storybook v7 work under the following circumstances:
    • Storybook Vite.js projects work
    • Storybook Webpack projects can use build-storybook
    • Storybook Webpack projects cannot use storybook - it fails
    • Storybook Angular projects work as expected

Next steps

  • Once the Storybook version that contains this fix gets published, the builder imports will be updated, and the options we are passing will be refactored to only use the CLIOptions

Note

This is part of a general effort to support Storybook 7. The effort will include a number of changes on Nx, like new generators, migrators, etc. This is the first addition in a series of many, to support the v7 Storybook builders through our executors.

Storybook 7 PRs

@vercel
Copy link

vercel bot commented Jan 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 11, 2023 at 3:34PM (UTC)

@mandarini mandarini self-assigned this Jan 10, 2023
@mandarini mandarini marked this pull request as ready for review January 10, 2023 17:15
@mandarini mandarini force-pushed the feat/storybook-7-builders branch 2 times, most recently from 32411e8 to 05abb89 Compare January 10, 2023 17:17
@mandarini mandarini force-pushed the feat/storybook-7-builders branch 4 times, most recently from 20fa71b to b08cb9b Compare January 11, 2023 15:04
@mandarini mandarini force-pushed the feat/storybook-7-builders branch from b08cb9b to 5dbc264 Compare January 11, 2023 15:33
@mandarini mandarini requested a review from jaysoo January 11, 2023 15:39
@mandarini mandarini enabled auto-merge (squash) January 11, 2023 15:54
@mandarini mandarini merged commit 9f75f7c into nrwl:master Jan 11, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants