core: dependsOn local project overrides regression (introduced between nx 19.4 - 19.5)
#27258
Closed
2 of 4 tasks
Assignees
Labels
Comments
Hotell
changed the title
dependsOn project overrides regression (introduced between nx 19.3 - 19.5)dependsOn local project overrides regression (introduced between nx 19.3 - 19.5)
1 task
|
@Hotell Can you provide more detail as to what I can clone and try to run from that PR that exhibits the problem? I tried to repro in a fresh run and did not see an issue. |
So to recap: Before (nx 19.3)
After (nx 19.5)
when trying to run lemme know if you need anything else. ty |
Hotell
changed the title
dependsOn local project overrides regression (introduced between nx 19.3 - 19.5)dependsOn local project overrides regression (introduced between nx 19.4 - 19.5)
|
Ok, got a minimal repro locally. Thanks for the info @Hotell 👋 |
|
This team rocks! Thx a ton folks for quick fix. 🍻 |
FrozenPandaz
pushed a commit
that referenced
this issue
Aug 7, 2024
…oject.json file (#27309) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior We don't infer scripts if any info for that target is present in project.json. This results in the target dissapearing if the user tries to modify the inferred target by providing info in project.json, for example by providing dependsOn or similar. A minimal repro of the issue looks something like this: > packages/foo/package.json ```json { "name": "foo", "scripts": { "build": "echo build" } } ``` > packages/foo/project.json ```json { "name": "foo", "targets": { "build": { "dependsOn": [] } } } ``` Attempting to run `nx build foo` results in "Cannot find configuration for task foo:build", as we remove the target for not having an executor. ## Expected Behavior The target remains as it can run the script, so we have to infer the script to begin with. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #27258 (cherry picked from commit 25212e3)
ZackDeRose
pushed a commit
to ZackDeRose/nx
that referenced
this issue
Aug 8, 2024
…oject.json file (nrwl#27309) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior We don't infer scripts if any info for that target is present in project.json. This results in the target dissapearing if the user tries to modify the inferred target by providing info in project.json, for example by providing dependsOn or similar. A minimal repro of the issue looks something like this: > packages/foo/package.json ```json { "name": "foo", "scripts": { "build": "echo build" } } ``` > packages/foo/project.json ```json { "name": "foo", "targets": { "build": { "dependsOn": [] } } } ``` Attempting to run `nx build foo` results in "Cannot find configuration for task foo:build", as we remove the target for not having an executor. ## Expected Behavior The target remains as it can run the script, so we have to infer the script to begin with. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes nrwl#27258
|
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current Behavior
dependsOnoverrides no longer workfollowing configuration worked with nx 19.3:
with nx 19.5 it doesn't work anymore:
Expected Behavior
dependsOnoverrides should work as before (merge of inferred target with manually specified bug)Workaround:
if full target definition is manually provided it works as before
GitHub Repo
microsoft/fluentui#32136
Steps to Reproduce
Nx Report
Failure Logs
No response
Package Manager Version
yarn v1
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: