chore: migrate to nx 19.5 #32136

Hotell · 2024-07-29T09:04:14Z

~~🛑 Blocked~~ by core: dependsOn local project overrides regression (introduced between nx 19.4 - 19.5) nrwl/nx#27258

Previous Behavior

New Behavior

See release blog announcement https://nx.dev/blog/nx-19-5-adds-stackblitz-new-features-and-more

Related Issue(s)

Resolves
- show project: renders duplicate target when using inferred task from package.json#scripts nrwl/nx#27143 -> fix(core): do not create projects twice from package.json nrwl/nx#26700
- core:runCommands: explicit --parallel argument doesn't override env variable NX_PARALLEL nrwl/nx#26903
Implements partially [Feature]: migrate to nx #30267

fabricteam · 2024-07-29T09:19:05Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
FluentProviderWithTheme	virtual-rerender	43	41	10	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	644	644	5000
Button	mount	300	309	5000
Field	mount	1140	1164	5000
FluentProvider	mount	714	718	5000
FluentProviderWithTheme	mount	85	73	10
FluentProviderWithTheme	virtual-rerender	43	41	10	Possible regression
FluentProviderWithTheme	virtual-rerender-with-unmount	83	77	10
MakeStyles	mount	861	882	50000
Persona	mount	1798	1732	5000
SpinButton	mount	1419	1390	5000
SwatchPicker	mount	1663	1670	5000

fabricteam · 2024-07-29T09:21:20Z

📊 Bundle size report

✅ No changes found

fabricteam · 2024-07-29T09:22:32Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2024-07-29T09:23:58Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
ButtonMinimalPerf.default	87	86	1.01:1	analysis

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AvatarMinimalPerf.default	117	102	1.15:1
FlexMinimalPerf.default	169	150	1.13:1
FormMinimalPerf.default	241	213	1.13:1
BoxMinimalPerf.default	206	188	1.1:1
ProviderMinimalPerf.default	216	197	1.1:1
AttachmentMinimalPerf.default	89	82	1.09:1
AlertMinimalPerf.default	166	154	1.08:1
ImageMinimalPerf.default	233	215	1.08:1
GridMinimalPerf.default	197	185	1.06:1
ListWith60ListItems.default	387	366	1.06:1
AccordionMinimalPerf.default	91	87	1.05:1
CardMinimalPerf.default	322	308	1.05:1
RadioGroupMinimalPerf.default	268	256	1.05:1
SliderMinimalPerf.default	762	728	1.05:1
TextMinimalPerf.default	201	191	1.05:1
VideoMinimalPerf.default	452	432	1.05:1
ButtonSlotsPerf.default	325	313	1.04:1
InputMinimalPerf.default	579	558	1.04:1
ReactionMinimalPerf.default	216	207	1.04:1
SkeletonMinimalPerf.default	203	196	1.04:1
AnimationMinimalPerf.default	309	301	1.03:1
DropdownMinimalPerf.default	1470	1421	1.03:1
LabelMinimalPerf.default	229	222	1.03:1
MenuMinimalPerf.default	511	496	1.03:1
MenuButtonMinimalPerf.default	972	945	1.03:1
TableMinimalPerf.default	239	232	1.03:1
ChatDuplicateMessagesPerf.default	162	159	1.02:1
ChatWithPopoverPerf.default	210	205	1.02:1
HeaderSlotsPerf.default	472	463	1.02:1
ListNestedPerf.default	333	326	1.02:1
PopupMinimalPerf.default	355	348	1.02:1
IconMinimalPerf.default	389	381	1.02:1
TooltipMinimalPerf.default	1296	1267	1.02:1
CheckboxMinimalPerf.default	1130	1124	1.01:1
ItemLayoutMinimalPerf.default	704	694	1.01:1
LayoutMinimalPerf.default	196	195	1.01:1
ButtonOverridesMissPerf.default	648	645	1:1
ListMinimalPerf.default	306	305	1:1
ProviderMergeThemesPerf.default	650	649	1:1
TextAreaMinimalPerf.default	285	286	1:1
CustomToolbarPrototype.default	1487	1491	1:1
CarouselMinimalPerf.default	260	262	0.99:1
DatepickerMinimalPerf.default	3823	3866	0.99:1
DialogMinimalPerf.default	449	455	0.99:1
DividerMinimalPerf.default	202	204	0.99:1
DropdownManyItemsPerf.default	394	399	0.99:1
RosterPerf.default	1576	1592	0.99:1
ToolbarMinimalPerf.default	543	547	0.99:1
AttachmentSlotsPerf.default	631	641	0.98:1
EmbedMinimalPerf.default	1848	1878	0.98:1
HeaderMinimalPerf.default	203	208	0.98:1
LoaderMinimalPerf.default	200	205	0.98:1
PortalMinimalPerf.default	85	87	0.98:1
TableManyItemsPerf.default	1077	1098	0.98:1
ChatMinimalPerf.default	444	460	0.97:1
ListCommonPerf.default	390	404	0.97:1
SegmentMinimalPerf.default	193	200	0.97:1
SplitButtonMinimalPerf.default	2242	2309	0.97:1
StatusMinimalPerf.default	385	401	0.96:1
TreeMinimalPerf.default	474	492	0.96:1
RefMinimalPerf.default	103	110	0.94:1
TreeWith60ListItems.default	78	86	0.91:1

fabricteam · 2024-07-29T09:34:17Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	640	611	5000
Breadcrumb	mount	1706	1688	1000
Checkbox	mount	1710	1715	5000
CheckboxBase	mount	1471	1492	5000
ChoiceGroup	mount	2953	2970	5000
ComboBox	mount	692	680	1000
CommandBar	mount	6607	6559	1000
ContextualMenu	mount	12308	12162	1000
DefaultButton	mount	801	809	5000
DetailsRow	mount	2292	2210	5000
DetailsRowFast	mount	2250	2249	5000
DetailsRowNoStyles	mount	2001	2008	5000
Dialog	mount	2829	2722	1000
DocumentCardTitle	mount	227	228	1000
Dropdown	mount	1994	1980	5000
FocusTrapZone	mount	1161	1181	5000
FocusZone	mount	1085	1072	5000
GroupedList	mount	42000	42377	2
GroupedList	virtual-rerender	20352	20169	2
GroupedList	virtual-rerender-with-unmount	52166	51735	2
GroupedListV2	mount	229	236	2
GroupedListV2	virtual-rerender	224	222	2
GroupedListV2	virtual-rerender-with-unmount	227	231	2
IconButton	mount	1158	1165	5000
Label	mount	338	351	5000
Layer	mount	2738	2778	5000
Link	mount	386	403	5000
MenuButton	mount	986	990	5000
MessageBar	mount	21479	21450	5000
Nav	mount	2023	2073	1000
OverflowSet	mount	792	787	5000
Panel	mount	1853	1831	1000
Persona	mount	784	764	1000
Pivot	mount	916	902	1000
PrimaryButton	mount	941	938	5000
Rating	mount	4662	4721	5000
SearchBox	mount	932	937	5000
Shimmer	mount	1930	1906	5000
Slider	mount	1328	1327	5000
SpinButton	mount	3027	3008	5000
Spinner	mount	378	384	5000
SplitButton	mount	1889	1923	5000
Stack	mount	425	434	5000
StackWithIntrinsicChildren	mount	882	903	5000
StackWithTextChildren	mount	2805	2792	5000
SwatchColorPicker	mount	6527	6396	5000
TagPicker	mount	1505	1453	5000
Text	mount	386	396	5000
TextField	mount	978	931	5000
ThemeProvider	mount	851	840	5000
ThemeProvider	virtual-rerender	584	585	5000
ThemeProvider	virtual-rerender-with-unmount	1291	1283	5000
Toggle	mount	616	618	5000
buttonNative	mount	180	182	5000

package.json

Hotell · 2024-08-15T15:06:25Z

/azp run

azure-pipelines · 2024-08-15T15:06:46Z

Azure Pipelines successfully started running 4 pipeline(s).

github-actions bot added this to the July Project Cycle Q3 2024 milestone Jul 29, 2024

Hotell added NX: core Area: Build System labels Jul 29, 2024

Hotell force-pushed the nx/migrate/19_4 branch from fa99290 to 644a0d0 Compare July 29, 2024 09:26

Hotell marked this pull request as ready for review July 29, 2024 15:23

Hotell requested a review from a team as a code owner July 29, 2024 15:23

tudorpopams approved these changes Jul 30, 2024

View reviewed changes

Hotell force-pushed the nx/migrate/19_4 branch from 644a0d0 to 7738d44 Compare August 1, 2024 08:42

github-actions bot modified the milestones: July Project Cycle Q3 2024, August Project Cycle Q3 2024 Aug 1, 2024

Hotell mentioned this pull request Aug 1, 2024

core: dependsOn local project overrides regression (introduced between nx 19.4 - 19.5) nrwl/nx#27258

Closed

4 tasks

Hotell force-pushed the nx/migrate/19_4 branch from 7d9dbdb to 4ace9a0 Compare August 1, 2024 12:31

Hotell added the Status: Blocked Resolution blocked by another issue label Aug 1, 2024

Hotell force-pushed the nx/migrate/19_4 branch 2 times, most recently from b455ea4 to 97b6d25 Compare August 8, 2024 08:31

fabricteam reviewed Aug 8, 2024

View reviewed changes

package.json Show resolved Hide resolved

Hotell removed the Status: Blocked Resolution blocked by another issue label Aug 8, 2024

Hotell force-pushed the nx/migrate/19_4 branch from 97b6d25 to 4045353 Compare August 9, 2024 12:08

Hotell enabled auto-merge (squash) August 9, 2024 12:08

Hotell force-pushed the nx/migrate/19_4 branch from 4045353 to a92f830 Compare August 12, 2024 15:36

fabricteam reviewed Aug 12, 2024

View reviewed changes

package.json Show resolved Hide resolved

Hotell requested review from marcosmoura and a team as code owners August 14, 2024 15:32

marcosmoura approved these changes Aug 14, 2024

View reviewed changes

Hotell force-pushed the nx/migrate/19_4 branch from 995085e to c048e13 Compare August 15, 2024 10:54

Hotell force-pushed the nx/migrate/19_4 branch from c048e13 to 7b5655c Compare August 15, 2024 11:21

fabricteam reviewed Aug 15, 2024

View reviewed changes

package.json Show resolved Hide resolved

Hotell added 2 commits August 15, 2024 14:27

style(workspace-plugin): remove unused eslint-disable directive

c304512

chore: migrate to nx 19.5.7

27bf2cd

Hotell force-pushed the nx/migrate/19_4 branch from 7b5655c to 27bf2cd Compare August 15, 2024 12:44

Hotell merged commit 1f5662c into microsoft:master Aug 15, 2024
23 checks passed

Hotell deleted the nx/migrate/19_4 branch August 16, 2024 07:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: migrate to nx 19.5 #32136

chore: migrate to nx 19.5 #32136

Hotell commented Jul 29, 2024 •

edited

Loading

fabricteam commented Jul 29, 2024 •

edited

Loading

fabricteam commented Jul 29, 2024 •

edited

Loading

fabricteam commented Jul 29, 2024 •

edited

Loading

fabricteam commented Jul 29, 2024 •

edited

Loading

fabricteam commented Jul 29, 2024 •

edited

Loading

Hotell commented Aug 15, 2024

azure-pipelines bot commented Aug 15, 2024

chore: migrate to nx 19.5 #32136

chore: migrate to nx 19.5 #32136

Conversation

Hotell commented Jul 29, 2024 • edited Loading

Previous Behavior

New Behavior

Related Issue(s)

fabricteam commented Jul 29, 2024 • edited Loading

Perf Analysis (@fluentui/react-components)

fabricteam commented Jul 29, 2024 • edited Loading

📊 Bundle size report

fabricteam commented Jul 29, 2024 • edited Loading

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam commented Jul 29, 2024 • edited Loading

Perf Analysis (@fluentui/react-northstar)

Potential regressions comparing to master

fabricteam commented Jul 29, 2024 • edited Loading

Perf Analysis (@fluentui/react)

Hotell commented Aug 15, 2024

azure-pipelines bot commented Aug 15, 2024

Hotell commented Jul 29, 2024 •

edited

Loading

fabricteam commented Jul 29, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Jul 29, 2024 •

edited

Loading

fabricteam commented Jul 29, 2024 •

edited

Loading

fabricteam commented Jul 29, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Jul 29, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react`)