-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esbuild should be a regular dependency, not a peerDependency, in @nx/angular #26770
Closed
1 of 4 tasks
Labels
Comments
daiscog
changed the title
esbuild should be a regular dependency, not a peerDependency, in @nx/agular
esbuild should be a regular dependency, not a peerDependency, in @nx/angular
Jul 1, 2024
meeroslav
pushed a commit
that referenced
this issue
Jul 23, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #26770
FrozenPandaz
pushed a commit
that referenced
this issue
Jul 24, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #26770 (cherry picked from commit e7c07ed)
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current Behavior
Given I have a monorepo containing an Angular app that I build with
@nx/angular
. I also have other arbitrary projects in the monorepo (not Angular apps) for which I want to use the latest version of esbuild to bundle.Then when attempting to install the latest version of esbuild as a devDependency in my monorepo, I get peerDependency conflict warnings.
Expected Behavior
I can use whatever version of esbuild I choose when using it directly and not be forced into using the same version that is used under the hood by
@nx/angular
.I believe it is semantically incorrect for
@nx/angular
to declareesbuild
as a peer dependency - it shouldn't need to share one instance with the entire monorepo. E.g.,@angular-devkit/build-angular
declaresesbuild
as a regular dependency, not a peer.Steps to Reproduce
pnpm add -D esbuild
Nx Report
Operating System
The text was updated successfully, but these errors were encountered: