Skip to content

Commit

Permalink
fix(angular): remove unnecessary esbuild peer dependency (#27046)
Browse files Browse the repository at this point in the history
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #26770

(cherry picked from commit e7c07ed)
  • Loading branch information
leosvelperez authored and FrozenPandaz committed Jul 24, 2024
1 parent 4dc68be commit ce4a7fb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
4 changes: 3 additions & 1 deletion packages/angular/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,9 @@
"stylus",
"tailwindcss",
// used in the CT angular plugin where Cy is already installed to use it.
"cypress"
"cypress",
// we have only one type import, so it's not a runtime dependency
"esbuild"
]
}
]
Expand Down
6 changes: 0 additions & 6 deletions packages/angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,8 @@
"@angular-devkit/core": ">= 16.0.0 < 19.0.0",
"@angular-devkit/schematics": ">= 16.0.0 < 19.0.0",
"@schematics/angular": ">= 16.0.0 < 19.0.0",
"esbuild": "^0.19.2",
"rxjs": "^6.5.3 || ^7.5.0"
},
"peerDependenciesMeta": {
"esbuild": {
"optional": true
}
},
"publishConfig": {
"access": "public"
}
Expand Down

0 comments on commit ce4a7fb

Please sign in to comment.