Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-native): upgrade react-native to 0.72 #17810

Merged
merged 1 commit into from
Jul 17, 2023
Merged

feat(react-native): upgrade react-native to 0.72 #17810

merged 1 commit into from
Jul 17, 2023

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Jun 27, 2023 •
edited
Loading

Current Behavior

Expected Behavior

  • expo detox working properly
  • react native run and build working properly
  • update migration scripts to be upgraded for nx 16.6
  • add migration scripts to update metro.config.js
  • fix expo metro.config.js

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jun 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 7:39pm

@nx-cloud
Copy link

nx-cloud bot commented Jun 27, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 67360da. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@xiongemi xiongemi force-pushed the feat/upgrade-react-native-72 branch from 3526968 to d98c27e Compare June 27, 2023 02:06
@xiongemi xiongemi force-pushed the feat/upgrade-react-native-72 branch from d98c27e to 69be23f Compare June 27, 2023 04:59
@ste7en
Copy link
Contributor

ste7en commented Jun 30, 2023

Can we have it bumped to 0.72.1 ?

@xiongemi
Copy link
Collaborator Author

Can we have it bumped to 0.72.1 ?

will do. still working on it.

@xiongemi xiongemi force-pushed the feat/upgrade-react-native-72 branch from 69be23f to 5e7b845 Compare July 5, 2023 13:41
@xiongemi xiongemi force-pushed the feat/upgrade-react-native-72 branch from 5e7b845 to a744cf8 Compare July 5, 2023 17:09
@xiongemi xiongemi force-pushed the feat/upgrade-react-native-72 branch from a744cf8 to 192b0dd Compare July 5, 2023 17:33
@xiongemi xiongemi force-pushed the feat/upgrade-react-native-72 branch from 192b0dd to f311551 Compare July 5, 2023 17:40
@xiongemi xiongemi force-pushed the feat/upgrade-react-native-72 branch from f311551 to 14b7a9b Compare July 7, 2023 16:31
@xiongemi xiongemi force-pushed the feat/upgrade-react-native-72 branch from 14b7a9b to bfef82a Compare July 8, 2023 05:35
@xiongemi xiongemi force-pushed the feat/upgrade-react-native-72 branch from bfef82a to 36c4155 Compare July 8, 2023 06:17
@xiongemi
Copy link
Collaborator Author

xiongemi commented Jul 8, 2023

still have an issue with dependency conflict with @config-plugins/detox
expo/config-plugins#178

probably after this pr got merged expo/config-plugins#179

@xiongemi xiongemi changed the title feat(react-native): upgrade react-native to 0.72.0 feat(react-native): upgrade react-native to 0.72.1 Jul 8, 2023
@xiongemi xiongemi force-pushed the feat/upgrade-react-native-72 branch from 36c4155 to 2287cc0 Compare July 8, 2023 06:36
@xiongemi xiongemi force-pushed the feat/upgrade-react-native-72 branch from 2287cc0 to 2258ef7 Compare July 13, 2023 03:07
@xiongemi
Copy link
Collaborator Author

still have an issue with dependency conflict with @config-plugins/detox expo/config-plugins#178

probably after this pr got merged expo/config-plugins#179

going to submit a separate pr to upgrade @config-plugins/detox in the future

@xiongemi xiongemi marked this pull request as ready for review July 13, 2023 04:14
@xiongemi xiongemi requested review from a team as code owners July 13, 2023 04:14
@xiongemi xiongemi force-pushed the feat/upgrade-react-native-72 branch from 2258ef7 to 26ec042 Compare July 13, 2023 04:30
@xiongemi xiongemi changed the title feat(react-native): upgrade react-native to 0.72.1 feat(react-native): upgrade react-native to 0.72 Jul 13, 2023
@xiongemi xiongemi force-pushed the feat/upgrade-react-native-72 branch from 26ec042 to 2a326e4 Compare July 13, 2023 14:08
@xiongemi xiongemi force-pushed the feat/upgrade-react-native-72 branch from 2a326e4 to 4350cc3 Compare July 13, 2023 18:18
@xiongemi xiongemi force-pushed the feat/upgrade-react-native-72 branch from 4350cc3 to 67360da Compare July 13, 2023 19:34
juristr
juristr approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to split this up into smaller recipes potentially, but for now this is good. We can do that in another follow-up PR later.

@xiongemi xiongemi merged commit 699a20c into nrwl:master Jul 17, 2023
@xiongemi xiongemi mentioned this pull request Jul 18, 2023
Closed
4 tasks
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@juristr juristr juristr approved these changes

@jaysoo jaysoo jaysoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xiongemi @ste7en @jaysoo @juristr @FrozenPandaz