expo plugin should use eas cli installed globally

[jer-sen]

Current Behavior

Plugin uses locally installed eas-cli package

Expected Behavior

Using version installed globally as stated in documentation https://github.com/expo/eas-cli
expo-doctor detects types incompatibility if adding eas-cli locally.

GitHub Repo

No response

Steps to Reproduce

nx/packages/expo/src/executors/update/update.impl.ts

Line 56 in 601c652

join(workspaceRoot, './node_modules/eas-cli/bin/run'),

Nx Report

>  NX   Report complete - copy this into the issue template

   Node   : 18.16.0
   OS     : win32-x64
   yarn   : 1.22.19

   nx                 : 16.4.0
   @nx/js             : 16.4.0
   @nx/jest           : 16.4.0
   @nx/linter         : 16.4.0
   @nx/workspace      : 16.4.0
   @nx/detox          : 16.4.0
   @nx/devkit         : 16.4.0
   @nx/eslint-plugin  : 16.4.0
   @nx/expo           : 16.4.0
   @nx/node           : 16.4.0
   @nx/react          : 16.4.0
   @nrwl/tao          : 16.4.0
   @nx/web            : 16.4.0
   @nx/webpack        : 16.4.0
   typescript         : 5.1.5

Failure Logs

No response

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

No response

[xiongemi]

i think this should be fixed in the pr #17810. now it is using require.resolve('eas-cli/bin/run'). this fix should be included in the next version of nx 16.6.0

[jer-sen]

If I'm right require.resolve('eas-cli/bin/run') will use local version not the globally installed version...

[github-actions]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

[LeoAnt02]

This is still an issue

Running command npx nx build <expo-project>

Give this error

> NX Cannot find module 'eas-cli/bin/run'

Issue is solved when eas-cli is installed locally directly into repo but
Eas convention favor the global install instead of local

From the official git eas-cli

Installing eas-cli to your project dependencies is strongly discouraged because it may cause dependency conflicts that are difficult to debug.

Source : https://github.com/expo/eas-cli

[LeoAnt02]

@xiongemi Is there any chance we could re-open #19290 ??
From what I understand it does fix the issue and rely on eas global

[xiongemi]

it should be fixed in nx 18. it should use global eas in that version. close this issue

[leggomuhgreggo]

FWIW, I think it's preferable to have it defined within the monorepo's root package.json — so I just reinstalled it after the recent migration removed it. But it's not a big deal either way — can leave it to users' discretion.

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.