Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: bump expo sdk to version 49 #179

Closed
wants to merge 6 commits into from
Closed

chore!: bump expo sdk to version 49 #179

wants to merge 6 commits into from

Conversation

chulanovskyi-bs
Copy link

Why

  • Recent release of a new SDK conflicts with the declared peer deps: issue

How

  • Bumped up the SDK version to 49 for each package and one script template

Test Plan

  • Rely on the configured Github Actions for verifying

@xiongemi xiongemi mentioned this pull request Jul 8, 2023
Merged
5 tasks
@egdelwonk
Copy link

Any idea when this will be merged and a new release of detox to support 49 sdk ?

Angel-Dijoux
Angel-Dijoux approved these changes Jul 13, 2023
View reviewed changes
Copy link

@Angel-Dijoux Angel-Dijoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice look great !!!

@EvanBacon
Copy link
Collaborator

You can't rely on GitHub for testing this, everything must be run locally.

@EvanBacon
Copy link
Collaborator

#180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Angel-Dijoux Angel-Dijoux Angel-Dijoux approved these changes

@EvanBacon EvanBacon Awaiting requested review from EvanBacon EvanBacon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chulanovskyi-bs @egdelwonk @EvanBacon @Angel-Dijoux